[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2019-01-24 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751743#comment-16751743 ] Tomás Fernández Löbbe commented on SOLR-12373: -- Attached a patch with the suggested change

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2019-01-16 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744492#comment-16744492 ] Hoss Man commented on SOLR-12373: - Tomas: LGTM ... although I would suggest pruning your

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2019-01-15 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743473#comment-16743473 ] Tomás Fernández Löbbe commented on SOLR-12373: -- [~hossman], let me know if you have any

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2018-12-14 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721898#comment-16721898 ] Tomás Fernández Löbbe commented on SOLR-12373: -- Updated the patch with the suggestions >

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2018-12-12 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719616#comment-16719616 ] Tomás Fernández Löbbe commented on SOLR-12373: -- Thanks for your review [~hossman], and sorry

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2018-05-18 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481304#comment-16481304 ] Hoss Man commented on SOLR-12373: - Tomas: you've obviously thought about this a lot more then i have, but

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2018-05-18 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481211#comment-16481211 ] Tomás Fernández Löbbe commented on SOLR-12373: -- Updated patch (and CR) addressing the

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2018-05-18 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480926#comment-16480926 ] Tomás Fernández Löbbe commented on SOLR-12373: -- Good Idea [~mbraun688]. I'll make the change

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2018-05-18 Thread Michael Braun (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480635#comment-16480635 ] Michael Braun commented on SOLR-12373: -- [~tomasflobbe] I can definitely see where this could be a

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2018-05-18 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480632#comment-16480632 ] Lucene/Solr QA commented on SOLR-12373: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields

2018-05-17 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479862#comment-16479862 ] Tomás Fernández Löbbe commented on SOLR-12373: -- Created CR