[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781227#comment-16781227 ] superman369 commented on SOLR-13156: h3. @[~mkhludnev], I originally thought that I hava no permission to create the issue that when facet with certain terms via \{!terms}, facet.limit, facet.offset does not work. the issue link is https://issues.apache.org/jira/browse/SOLR-13283 please help me resolve it. Thank you very much! > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Fix For: 7.7, 8.0, master (9.0) > > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780385#comment-16780385 ] Mikhail Khludnev commented on SOLR-13156: - bq. tell me the new link. I want to trace the issue's status I'm not aware of it. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Fix For: 7.7, 8.0, master (9.0) > > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779967#comment-16779967 ] superman369 commented on SOLR-13156: h4. @[~mkhludnev], if resolve the issue that facet.limit, facet.offset does not work , please tell me! Is the issue link changed? h4. if so,please tell me the new link. I want to trace the issue's status. Thank you very much! > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Fix For: 7.7, 8.0, master (9.0) > > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777682#comment-16777682 ] superman369 commented on SOLR-13156: @[~mkhludnev],Thanks for your reply! I am looking forward to it! > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Fix For: 7.7, 8.0, master (9.0) > > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777674#comment-16777674 ] Mikhail Khludnev commented on SOLR-13156: - bq. but facet.limit, facet.offset does not work. What's wrong? No one promise they will. They deserve a separate issue, patches are welcome. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Fix For: 7.7, 8.0, master (9.0) > > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777556#comment-16777556 ] superman369 commented on SOLR-13156: h4. [~mkhludnev], I do a test in solr7.7. Limiting field facet with certain terms via \{!terms} is work use facet.sort=count, but facet.limit, facet.offset does not work. What's wrong? h4. for example: h4. facet.field=\{!terms='1453,1452,1248'}location.authorIds=true=1=1, facet result h4. "location.authorIds" has 3 items. I think it should have one item. Could you help me? Thank you very much! > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Fix For: 7.7, 8.0, master (9.0) > > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753964#comment-16753964 ] ASF subversion and git services commented on SOLR-13156: Commit 513ba75f3f801de80ea757bfb94e8dbdd0a0f7f0 in lucene-solr's branch refs/heads/branch_8x from Mikhail Khludnev [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=513ba75 ] SOLR-13156: support facet.sort for facet.field={!terms=foo,bar}field > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753959#comment-16753959 ] ASF subversion and git services commented on SOLR-13156: Commit 14c50a22511ed8bbfa2482f46b6eed42df09772d in lucene-solr's branch refs/heads/branch_7x from Mikhail Khludnev [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=14c50a2 ] SOLR-13156: support facet.sort for facet.field={!terms=foo,bar}field > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753951#comment-16753951 ] ASF subversion and git services commented on SOLR-13156: Commit 43f2723213ed403a9f58d813d391ef26c961d909 in lucene-solr's branch refs/heads/master from Mikhail Khludnev [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=43f2723 ] SOLR-13156: support facet.sort for facet.field={!terms=foo,bar}field > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753591#comment-16753591 ] Lucene/Solr QA commented on SOLR-13156: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 42s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 2m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate ref guide {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 78m 2s{color} | {color:red} core in the patch failed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 90m 25s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | solr.cloud.TestCloudRecovery2 | | | solr.cloud.autoscaling.sim.TestSimExtremeIndexing | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | SOLR-13156 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12956510/SOLR-13156.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns validaterefguide | | uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / 8e69d12 | | ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 | | Default Java | 1.8.0_191 | | unit | https://builds.apache.org/job/PreCommit-SOLR-Build/271/artifact/out/patch-unit-solr_core.txt | | Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/271/testReport/ | | modules | C: solr solr/core solr/solr-ref-guide U: solr | | Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/271/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Assignee: Mikhail Khludnev >Priority: Major > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751881#comment-16751881 ] Lucene/Solr QA commented on SOLR-13156: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 39s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 39m 59s{color} | {color:green} core in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 45m 55s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | SOLR-13156 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12956140/SOLR-13156.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / c317119 | | ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 | | Default Java | 1.8.0_191 | | Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/268/testReport/ | | modules | C: solr/core U: solr/core | | Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/268/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > Attachments: SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751404#comment-16751404 ] Andrey Kudryavtsev commented on SOLR-13156: --- {code:java} protected NamedList getListedTermCounts(String field, final ParsedParams parsed, List terms) throws IOException { final SolrParams params = parsed.params; Integer mincount = parsed.params.getFieldInt(field, FacetParams.FACET_MINCOUNT); int offset = params.getFieldInt(field, FacetParams.FACET_OFFSET, 0); int limit = params.getFieldInt(field, FacetParams.FACET_LIMIT, 100); if (limit == 0) return new NamedList<>(); if (mincount==null) { Boolean zeros = params.getFieldBool(field, FacetParams.FACET_ZEROS); mincount = (zeros!=null && !zeros) ? 1 : 0; } boolean missing = params.getFieldBool(field, FacetParams.FACET_MISSING, false); String sort = params.getFieldParam(field, FacetParams.FACET_SORT); String prefix = params.getFieldParam(field, FacetParams.FACET_PREFIX); final HashSet includeTerms = new HashSet<>(terms); final Predicate termFilter = bytesRef -> includeTerms.contains(bytesRef.utf8ToString()); boolean exists = params.getFieldBool(field, FacetParams.FACET_EXISTS, false); return getFacetTermEnumCounts(searcher, parsed.docs, field, offset, limit, mincount, missing, sort, prefix, termFilter, exists); }{code} "List terms order' doesn't work obviously, but 'code reusing' level is high. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > Attachments: SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751050#comment-16751050 ] Mikhail Khludnev commented on SOLR-13156: - mincount is a subject for further work, if there's no shortcut to handle it via common routine. Also, enumerating terms out of order might have performance penalty, but again it's a separate topic. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751027#comment-16751027 ] Konstantin Perikov commented on SOLR-13156: --- [~mkhludnev] [~ysee...@gmail.com] I just figured out, that others features aren't working here as well (e.g. facet.mincount) Any ideas on this one? > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751000#comment-16751000 ] ASF subversion and git services commented on SOLR-13156: Commit e68697a6de0b380665e9d2d787953035102c318c in lucene-solr's branch refs/heads/master-deprecations from Mikhail Khludnev [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e68697a ] SOLR-13156: documenting functionality gap. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750975#comment-16750975 ] Konstantin Perikov commented on SOLR-13156: --- [~superman369] I hope to provide patch relatively quick, however I have no idea how long it would take to go through the review/release process, etc. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750592#comment-16750592 ] superman369 commented on SOLR-13156: @[~ysee...@gmail.com], thank you very much! could you tell me that you estimate how long to solve the issue? I am anxious about the issue, because i need the feature. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749886#comment-16749886 ] Yonik Seeley commented on SOLR-13156: - Interesting IIRC, this wasn't a public API, and was only used internally for facet refinement (hence no need for sorting.) It looks like at some point it got documented as a public API, so I guess it is now. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749719#comment-16749719 ] superman369 commented on SOLR-13156: I met the issue and thanks for the post. I want to know that how long dose it take to solve the issue? I very need the feature. Thank you very much! > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748990#comment-16748990 ] Mikhail Khludnev commented on SOLR-13156: - Here's the spec proposal: {quote} Limiting terms changes default for {{facet.sort}}: if it's omitted facet values returned in the as-given order. It can be explicitly overridden by values {{index}} and {{count}}. {quote} WDYT? ccing [~yo...@apache.org] > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748648#comment-16748648 ] ASF subversion and git services commented on SOLR-13156: Commit e68697a6de0b380665e9d2d787953035102c318c in lucene-solr's branch refs/heads/master from Mikhail Khludnev [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e68697a ] SOLR-13156: documenting functionality gap. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748656#comment-16748656 ] ASF subversion and git services commented on SOLR-13156: Commit 7c21445daab611aa37010964fd61f1e31bfbb58b in lucene-solr's branch refs/heads/branch_8x from Mikhail Khludnev [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=7c21445 ] SOLR-13156: documenting functionality gap. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748651#comment-16748651 ] ASF subversion and git services commented on SOLR-13156: Commit 1911b3f71ef83f568993106ccd97cff35205f8da in lucene-solr's branch refs/heads/branch_7x from Mikhail Khludnev [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1911b3f ] SOLR-13156: documenting functionality gap. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748581#comment-16748581 ] Mikhail Khludnev commented on SOLR-13156: - I'm in doubts. I feel like {{facet.sort}} should work as usual in case of term limiting, but {{facet.sort}} doesn't have an _as-given_ option. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748012#comment-16748012 ] Konstantin Perikov commented on SOLR-13156: --- [~janhoy], apparently this feature was there for a while, at the very least. I will provide patch with a test soon, so it could be easily reproducible > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13156) Limiting field facet with certain terms via {!terms} not taking into account sorting
[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748002#comment-16748002 ] Jan Høydahl commented on SOLR-13156: I didn't even know about this feature. For reference, see [https://lucene.apache.org/solr/guide/7_6/faceting.html#limiting-facet-with-certain-terms] So it is nice to be able to specify the order like you do, but when you explicitly specify a facet.sort I agree that it should re-sort based on that... > Limiting field facet with certain terms via {!terms} not taking into account > sorting > > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Konstantin Perikov >Priority: Major > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title=count=on=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title=count=on=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org