[jira] [Commented] (SOLR-13576) factor out a TopGroupsShardResponseProcessor.fillResultIds method

2019-07-05 Thread Diego Ceccarelli (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879333#comment-16879333 ] Diego Ceccarelli commented on SOLR-13576: - LGTM, thanksĀ [~cpoerschke] > factor out a

[jira] [Commented] (SOLR-13576) factor out a TopGroupsShardResponseProcessor.fillResultIds method

2019-06-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875121#comment-16875121 ] ASF subversion and git services commented on SOLR-13576: Commit

[jira] [Commented] (SOLR-13576) factor out a TopGroupsShardResponseProcessor.fillResultIds method

2019-06-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875111#comment-16875111 ] ASF subversion and git services commented on SOLR-13576: Commit

[jira] [Commented] (SOLR-13576) factor out a TopGroupsShardResponseProcessor.fillResultIds method

2019-06-28 Thread Christine Poerschke (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875095#comment-16875095 ] Christine Poerschke commented on SOLR-13576: {quote}The patch doesn't appear to include any

[jira] [Commented] (SOLR-13576) factor out a TopGroupsShardResponseProcessor.fillResultIds method

2019-06-25 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872809#comment-16872809 ] Lucene/Solr QA commented on SOLR-13576: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-13576) factor out a TopGroupsShardResponseProcessor.fillResultIds method

2019-06-25 Thread Christine Poerschke (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872273#comment-16872273 ] Christine Poerschke commented on SOLR-13576: "factor out a

[jira] [Commented] (SOLR-13576) factor out a TopGroupsShardResponseProcessor.fillResultIds method

2019-06-25 Thread Christine Poerschke (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872272#comment-16872272 ] Christine Poerschke commented on SOLR-13576: In the context of SOLR-11831 the method (if it