[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904596#comment-16904596 ] Tomoko Uchida commented on SOLR-13593: -- Here is the final patch: [^SOLR-13593.patch] I opened

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904591#comment-16904591 ] ASF subversion and git services commented on SOLR-13593: Commit

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904584#comment-16904584 ] Tomoko Uchida commented on SOLR-13593: -- ICU factory "name" argument was changed to "form" on the

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904475#comment-16904475 ] Tomoko Uchida commented on SOLR-13593: -- When I grepped entire lucene code there are only two (ICU)

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904461#comment-16904461 ] Uwe Schindler commented on SOLR-13593: -- "form" looks fine. Thanks, makes more sense from my

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904460#comment-16904460 ] Tomoko Uchida commented on SOLR-13593: -- FYI, the "name" should come from ICU4J library's method

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904452#comment-16904452 ] Uwe Schindler commented on SOLR-13593: -- I tend to break the ICU factory. The name attribute makes no

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904430#comment-16904430 ] Tomoko Uchida commented on SOLR-13593: -- When running entire test, I encountered a TokenFilterFactory

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901888#comment-16901888 ] Uwe Schindler commented on SOLR-13593: -- Looks good to me! +1 > Allow to specify analyzer components

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901689#comment-16901689 ] Tomoko Uchida commented on SOLR-13593: -- I updated the pull request. If both of "name" and "class"

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900067#comment-16900067 ] Steve Rowe commented on SOLR-13593: --- bq. Both name & class seems error prone; can't we simply disallow

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900066#comment-16900066 ] Tomoko Uchida commented on SOLR-13593: -- Thanks [~dsmiley], I agree with you. I will update the PR

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899969#comment-16899969 ] David Smiley commented on SOLR-13593: - Both name & class seems error prone; can't we simply disallow

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899602#comment-16899602 ] Tomoko Uchida commented on SOLR-13593: -- I have updated the pull request. 1. If both of "name" and

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883151#comment-16883151 ] Tomoko Uchida commented on SOLR-13593: -- Just as a reminder, I reverted LUCENE-8778 so I will not be

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881892#comment-16881892 ] Tomoko Uchida commented on SOLR-13593: -- I opened an blocker issue: LUCENE-8907. [~thetaphi]:

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881872#comment-16881872 ] Jan Høydahl commented on SOLR-13593: +1 for a back-compact blocker issue for 8.2 > Allow to specify

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881868#comment-16881868 ] Uwe Schindler commented on SOLR-13593: -- Hi, I am not fully sure how to handle that in 8.x. I just

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881863#comment-16881863 ] Tomoko Uchida commented on SOLR-13593: -- Hi [~thetaphi], thanks for the comment, I've already

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881845#comment-16881845 ] Uwe Schindler commented on SOLR-13593: -- While thinking about the next 8.x release: Actually because

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881841#comment-16881841 ] Uwe Schindler commented on SOLR-13593: -- Changes look good. I think we can commit this separately and

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881764#comment-16881764 ] Tomoko Uchida commented on SOLR-13593: -- Hi [~dsmiley], thanks for your suggestion. I will open

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881500#comment-16881500 ] David Smiley commented on SOLR-13593: - I really like this change! Love "name". I think you can make

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881010#comment-16881010 ] Tomoko Uchida commented on SOLR-13593: -- Hi, The changes seem trivial so I will be able to add

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878792#comment-16878792 ] Tomoko Uchida commented on SOLR-13593: -- I updated the pull request. {quote}I am not so happy about

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878426#comment-16878426 ] Uwe Schindler commented on SOLR-13593: -- Hi, I am not so happy about the "spi" name, I'd perfer

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878369#comment-16878369 ] Tomoko Uchida commented on SOLR-13593: -- I've opened a draft pull request:

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878294#comment-16878294 ] Tomoko Uchida commented on SOLR-13593: -- I started playing with {{FieldTypePluginLoader}} and noticed

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876372#comment-16876372 ] Varun Thacker commented on SOLR-13593: -- {quote}I agree with this idea! Meanwhile I think the field

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876247#comment-16876247 ] Tomoko Uchida commented on SOLR-13593: -- This issue does not intend to replace current "class=...",

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876230#comment-16876230 ] Tomoko Uchida commented on SOLR-13593: -- [~varunthacker]: sorry, I made mistakes in my description. I

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876223#comment-16876223 ] Varun Thacker commented on SOLR-13593: -- +1 for having the ability to say "whitespace" etc Is the