[jira] [Commented] (SOLR-13702) Some components register twice their metric names

2019-08-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914526#comment-16914526
 ] 

ASF subversion and git services commented on SOLR-13702:


Commit 4c9691ef191441add8c1f91e54d9d52775f395a7 in lucene-solr's branch 
refs/heads/branch_8x from Jan Høydahl
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4c9691e ]

SOLR-13702: Some components register twice their metric names (#834)

(cherry picked from commit 0aa3654802fa8fd7da27c80619248b92b3ac6af5)


> Some components register twice their metric names
> -
>
> Key: SOLR-13702
> URL: https://issues.apache.org/jira/browse/SOLR-13702
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Andrzej Bialecki 
>Assignee: Jan Høydahl
>Priority: Minor
> Fix For: 8.3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Spin-off from SOLR-13700.
> Both {{AuditLoggerPlugin.initializeMetrics}} and 
> {{AuthenticationPlugin.initializeMetrics}} needlessly add metrics names to 
> {{metricNames}} - this is already done as a part of each respective metric 
> registration by using {{SolrInfoBean.this.registerName(name)}}.
> There may be other components that do this, too.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-13702) Some components register twice their metric names

2019-08-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914527#comment-16914527
 ] 

ASF subversion and git services commented on SOLR-13702:


Commit 035d823acf752d5794cfd07e133a918f0fb6b8c6 in lucene-solr's branch 
refs/heads/branch_8x from Jan Høydahl
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=035d823 ]

SOLR-13702: Fix precommit


> Some components register twice their metric names
> -
>
> Key: SOLR-13702
> URL: https://issues.apache.org/jira/browse/SOLR-13702
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Andrzej Bialecki 
>Assignee: Jan Høydahl
>Priority: Minor
> Fix For: 8.3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Spin-off from SOLR-13700.
> Both {{AuditLoggerPlugin.initializeMetrics}} and 
> {{AuthenticationPlugin.initializeMetrics}} needlessly add metrics names to 
> {{metricNames}} - this is already done as a part of each respective metric 
> registration by using {{SolrInfoBean.this.registerName(name)}}.
> There may be other components that do this, too.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-13702) Some components register twice their metric names

2019-08-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914449#comment-16914449
 ] 

ASF subversion and git services commented on SOLR-13702:


Commit 07f136480006b3db4baaf5a96215954450d4b83e in lucene-solr's branch 
refs/heads/master from Jan Høydahl
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=07f1364 ]

SOLR-13702: Fix precommit


> Some components register twice their metric names
> -
>
> Key: SOLR-13702
> URL: https://issues.apache.org/jira/browse/SOLR-13702
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Andrzej Bialecki 
>Assignee: Jan Høydahl
>Priority: Minor
> Fix For: 8.3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Spin-off from SOLR-13700.
> Both {{AuditLoggerPlugin.initializeMetrics}} and 
> {{AuthenticationPlugin.initializeMetrics}} needlessly add metrics names to 
> {{metricNames}} - this is already done as a part of each respective metric 
> registration by using {{SolrInfoBean.this.registerName(name)}}.
> There may be other components that do this, too.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-13702) Some components register twice their metric names

2019-08-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914262#comment-16914262
 ] 

ASF subversion and git services commented on SOLR-13702:


Commit 0aa3654802fa8fd7da27c80619248b92b3ac6af5 in lucene-solr's branch 
refs/heads/master from Jan Høydahl
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0aa3654 ]

SOLR-13702: Some components register twice their metric names (#834)



> Some components register twice their metric names
> -
>
> Key: SOLR-13702
> URL: https://issues.apache.org/jira/browse/SOLR-13702
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Andrzej Bialecki 
>Assignee: Jan Høydahl
>Priority: Minor
> Fix For: 8.3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Spin-off from SOLR-13700.
> Both {{AuditLoggerPlugin.initializeMetrics}} and 
> {{AuthenticationPlugin.initializeMetrics}} needlessly add metrics names to 
> {{metricNames}} - this is already done as a part of each respective metric 
> registration by using {{SolrInfoBean.this.registerName(name)}}.
> There may be other components that do this, too.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-13702) Some components register twice their metric names

2019-08-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/SOLR-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909127#comment-16909127
 ] 

Jan Høydahl commented on SOLR-13702:


Did not find any other than these two. Will commit soon, trivial patch.

> Some components register twice their metric names
> -
>
> Key: SOLR-13702
> URL: https://issues.apache.org/jira/browse/SOLR-13702
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Andrzej Bialecki 
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Spin-off from SOLR-13700.
> Both {{AuditLoggerPlugin.initializeMetrics}} and 
> {{AuthenticationPlugin.initializeMetrics}} needlessly add metrics names to 
> {{metricNames}} - this is already done as a part of each respective metric 
> registration by using {{SolrInfoBean.this.registerName(name)}}.
> There may be other components that do this, too.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org