[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204672#comment-13204672
]
James Dyer commented on SOLR-2191:
--
With SOLR-3022 and SOLR-3032 complete, should this one
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204686#comment-13204686
]
Mark Miller commented on SOLR-2191:
---
Sure, makes sense to me.
Change
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185010#comment-13185010
]
David Smiley commented on SOLR-2191:
I agree with Mark. In code I write, I am always
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185019#comment-13185019
]
Yonik Seeley commented on SOLR-2191:
bq. Why? You just include the extra context in the
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185023#comment-13185023
]
Erick Erickson commented on SOLR-2191:
--
OK, this really breaks out into two parts.
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185074#comment-13185074
]
Erick Erickson commented on SOLR-2191:
--
One last comment. Let's move further
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184299#comment-13184299
]
Mark Miller commented on SOLR-2191:
---
The issue needs to be updated. I think the right
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184417#comment-13184417
]
Erick Erickson commented on SOLR-2191:
--
What does remove logOnce mean in this case?
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1318#comment-1318
]
Mark Miller commented on SOLR-2191:
---
bq. personal problem that should be dealt with on a
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184657#comment-13184657
]
Yonik Seeley commented on SOLR-2191:
bq. I think it's more of a project level problem -
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184684#comment-13184684
]
Mark Miller commented on SOLR-2191:
---
bq. Logging last means your missing context for
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181193#comment-13181193
]
Sami Siren commented on SOLR-2191:
--
I also ran into this problem too (SOLR-3006).
b1. I
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181362#comment-13181362
]
David Smiley commented on SOLR-2191:
Yes please commit this for pete's sake! This is
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13028240#comment-13028240
]
David Smiley commented on SOLR-2191:
Ehh... I kind of like the notion but wether it is
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13028246#comment-13028246
]
Yonik Seeley commented on SOLR-2191:
bq. In code I write, I tend to almost never log
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027915#comment-13027915
]
Hoss Man commented on SOLR-2191:
Is anyone else interested in entertaining the notion that
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13026714#comment-13026714
]
David Smiley commented on SOLR-2191:
Yes, lets do this! I was just about to log a bug
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13026794#comment-13026794
]
Mark Miller commented on SOLR-2191:
---
bq. Why didn't you simply commit it? I heard on the
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13026799#comment-13026799
]
Mark Miller commented on SOLR-2191:
---
Also keep in mind that Review-Then-Commit at Apache
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13026798#comment-13026798
]
Mark Miller commented on SOLR-2191:
---
Also keep in mind that Review-Then-Commit at Apache
[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13026830#comment-13026830
]
David Smiley commented on SOLR-2191:
Thanks for clarification on Review Then Commit
21 matches
Mail list logo