[
https://issues.apache.org/jira/browse/SOLR-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107489#comment-13107489
]
Robert Muir commented on SOLR-2754:
---
Thanks David, I took your patch and I'm adding tests
[
https://issues.apache.org/jira/browse/SOLR-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107069#comment-13107069
]
David Mark Nemeskey commented on SOLR-2754:
---
bq. Well, we can do both: we can
[
https://issues.apache.org/jira/browse/SOLR-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107116#comment-13107116
]
Robert Muir commented on SOLR-2754:
---
+1
create Solr similarity factories for new
[
https://issues.apache.org/jira/browse/SOLR-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106683#comment-13106683
]
David Mark Nemeskey commented on SOLR-2754:
---
Robert, I've reviewed the patch.
[
https://issues.apache.org/jira/browse/SOLR-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106707#comment-13106707
]
Robert Muir commented on SOLR-2754:
---
Thanks for the review David!
{quote}
[
https://issues.apache.org/jira/browse/SOLR-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106795#comment-13106795
]
David Mark Nemeskey commented on SOLR-2754:
---
bq. Alternative, another idea would
[
https://issues.apache.org/jira/browse/SOLR-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106924#comment-13106924
]
Robert Muir commented on SOLR-2754:
---
{quote}
I can understand the reasoning behind this