[jira] [Commented] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters
[ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405147#comment-13405147 ] Michael Dodsworth commented on SOLR-3467: - much appreciated, Jan. Thank you. ExtendedDismax escaping is missing several reserved characters -- Key: SOLR-3467 URL: https://issues.apache.org/jira/browse/SOLR-3467 Project: Solr Issue Type: Bug Components: query parsers Affects Versions: 3.6 Reporter: Michael Dodsworth Assignee: Jan Høydahl Priority: Minor Fix For: 4.0, 5.0 Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped). Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '', '/'}} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters
[ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402910#comment-13402910 ] Jan Høydahl commented on SOLR-3467: --- Yea, I see that. Actually, I cannot get the test to fail, even with 3.6.0 - is there a better way to trigger the missing escaping of particularly '', '\\' and '|' ? If not, then I cannot see a need for a 3.6.x patch. ExtendedDismax escaping is missing several reserved characters -- Key: SOLR-3467 URL: https://issues.apache.org/jira/browse/SOLR-3467 Project: Solr Issue Type: Bug Components: query parsers Affects Versions: 3.6 Reporter: Michael Dodsworth Assignee: Jan Høydahl Priority: Minor Fix For: 4.0, 3.6.1, 5.0 Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped). Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '', '/'}} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters
[ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402287#comment-13402287 ] Michael Dodsworth commented on SOLR-3467: - Thank you, Jan. From what I can tell, '/' only became a reserved character since 4.0 - https://issues.apache.org/jira/browse/LUCENE-2604. ExtendedDismax escaping is missing several reserved characters -- Key: SOLR-3467 URL: https://issues.apache.org/jira/browse/SOLR-3467 Project: Solr Issue Type: Bug Components: query parsers Affects Versions: 3.6 Reporter: Michael Dodsworth Assignee: Jan Høydahl Priority: Minor Fix For: 4.0, 3.6.1, 5.0 Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped). Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '', '/'}} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters
[ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401430#comment-13401430 ] Jan Høydahl commented on SOLR-3467: --- Great. Are you able to add a JUnit test which reproduces the bug and shows that it is fixed? ExtendedDismax escaping is missing several reserved characters -- Key: SOLR-3467 URL: https://issues.apache.org/jira/browse/SOLR-3467 Project: Solr Issue Type: Bug Components: query parsers Affects Versions: 4.0 Reporter: Michael Dodsworth Priority: Minor Fix For: 4.0 Attachments: SOLR-3467.patch When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped). Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '', '/'}} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters
[ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400895#comment-13400895 ] Michael Dodsworth commented on SOLR-3467: - all feedback/review comments welcome ExtendedDismax escaping is missing several reserved characters -- Key: SOLR-3467 URL: https://issues.apache.org/jira/browse/SOLR-3467 Project: Solr Issue Type: Bug Components: query parsers Affects Versions: 4.0 Reporter: Michael Dodsworth Priority: Minor Fix For: 4.0 Attachments: SOLR-3467.patch When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped). Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '', '/'}} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org