[
https://issues.apache.org/jira/browse/SOLR-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699081#comment-13699081
]
Anshum Gupta commented on SOLR-4693:
I'll just go through the patch tonight. Also, here
[
https://issues.apache.org/jira/browse/SOLR-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699742#comment-13699742
]
Anshum Gupta commented on SOLR-4693:
Looks good to me other than a small suggestion.
[
https://issues.apache.org/jira/browse/SOLR-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13694566#comment-13694566
]
Anshum Gupta commented on SOLR-4693:
Thanks for the feedback [~shalinmangar].
The
[
https://issues.apache.org/jira/browse/SOLR-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13695270#comment-13695270
]
Shalin Shekhar Mangar commented on SOLR-4693:
-
bq. We 'can' but I feel we
[
https://issues.apache.org/jira/browse/SOLR-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670552#comment-13670552
]
Shalin Shekhar Mangar commented on SOLR-4693:
-
Thanks Anshum.
A few comments:
[
https://issues.apache.org/jira/browse/SOLR-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631608#comment-13631608
]
Anshum Gupta commented on SOLR-4693:
Also, here's how the API call looks like:
[
https://issues.apache.org/jira/browse/SOLR-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631752#comment-13631752
]
Yonik Seeley commented on SOLR-4693:
bq. Have added a todo to perhaps allow deletion of
[
https://issues.apache.org/jira/browse/SOLR-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631764#comment-13631764
]
Anshum Gupta commented on SOLR-4693:
bq. And we should allow deletion if the slice has
