[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941316#comment-14941316
]
Mark Miller commented on SOLR-7746:
---
FY on the CHANGES.txt entry for this one:
{noformat}
SOLR-7746:
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941394#comment-14941394
]
Gregory Chanan commented on SOLR-7746:
--
Thanks Mark, both the "via" and reporter points make sense.
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941458#comment-14941458
]
Mark Miller commented on SOLR-7746:
---
Yeah, personally I think it's worth it for the reporter credit.
>
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941896#comment-14941896
]
ASF subversion and git services commented on SOLR-7746:
---
Commit 1706499 from
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941908#comment-14941908
]
ASF subversion and git services commented on SOLR-7746:
---
Commit 1706502 from
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741829#comment-14741829
]
ASF subversion and git services commented on SOLR-7746:
---
Commit 1702581 from
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741831#comment-14741831
]
ASF subversion and git services commented on SOLR-7746:
---
Commit 1702582 from
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731661#comment-14731661
]
Michael Sun commented on SOLR-7746:
---
Thanks [~gchanan] for pointing it out. I updated the patch and
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730038#comment-14730038
]
Gregory Chanan commented on SOLR-7746:
--
Actually I found a problem with the test. It looks like
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726269#comment-14726269
]
Gregory Chanan commented on SOLR-7746:
--
+1 lgtm.
> Ping requests stopped working with distrib=true in
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723848#comment-14723848
]
Michael Sun commented on SOLR-7746:
---
That makes sense. The updated patch is uploaded. Thanks [~gchanan]
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717605#comment-14717605
]
Michael Sun commented on SOLR-7746:
---
Thanks [~gchanan] for your comments. The updated
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715804#comment-14715804
]
Gregory Chanan commented on SOLR-7746:
--
1. You should not modify
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715882#comment-14715882
]
Gregory Chanan commented on SOLR-7746:
--
I compared what happens in 5.1 vs your version
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712297#comment-14712297
]
Michael Sun commented on SOLR-7746:
---
Attach patch with test. I tested that the test is
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707039#comment-14707039
]
Michael Sun commented on SOLR-7746:
---
Thanks [~gchanan] for reviewing. Here is my answers.
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707066#comment-14707066
]
Gregory Chanan commented on SOLR-7746:
--
on #3, sorry I didn't write that correctly.
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706065#comment-14706065
]
Gregory Chanan commented on SOLR-7746:
--
Looks good Michael, a few questions/comments:
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705757#comment-14705757
]
Michael Sun commented on SOLR-7746:
---
Upload the patch to handle sharded ping requests
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703885#comment-14703885
]
Michael Sun commented on SOLR-7746:
---
Yeah, that makes sense. Thanks [~gchanan] for
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702234#comment-14702234
]
Gregory Chanan commented on SOLR-7746:
--
Can we put the complexity in the
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699905#comment-14699905
]
Michael Sun commented on SOLR-7746:
---
Attach a fix. For the ping request particular, there
[
https://issues.apache.org/jira/browse/SOLR-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697353#comment-14697353
]
Michael Sun commented on SOLR-7746:
---
This issue can be reproduced in trunk build too.
23 matches
Mail list logo
