[jira] [Commented] (SOLR-7880) Update commons-cli to 1.3.1, fix usage of deprecated classes/methods
[ https://issues.apache.org/jira/browse/SOLR-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005406#comment-16005406 ] Mike Drob commented on SOLR-7880: - [~elyograg] - Do you want to take a look at this again? Commons-cli is up to 1.4, and we've dropped the morphlines contrib, so there patch needs a few updates, but in general I think it's a good idea. > Update commons-cli to 1.3.1, fix usage of deprecated classes/methods > > > Key: SOLR-7880 > URL: https://issues.apache.org/jira/browse/SOLR-7880 > Project: Solr > Issue Type: Improvement > Components: scripts and tools >Affects Versions: 5.2.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey > Fix For: 5.5 > > Attachments: SOLR-7880.patch, SOLR-7880.patch, SOLR-7880.patch > > > While looking at SOLR-7847, I noticed that commons-cli was an old version, > and once I upgraded it in the ivy config, found that SolrCLI is using > deprecated classes/methods. > This issue is to complete the upgrade and fix the deprecations. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7880) Update commons-cli to 1.3.1, fix usage of deprecated classes/methods
[ https://issues.apache.org/jira/browse/SOLR-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661426#comment-14661426 ] Shawn Heisey commented on SOLR-7880: Tests and precommit passed. Several random bin\solr commands also worked. After fixing the script to accept Ant 1.9, nightly-smoke passed too. Update commons-cli to 1.3.1, fix usage of deprecated classes/methods Key: SOLR-7880 URL: https://issues.apache.org/jira/browse/SOLR-7880 Project: Solr Issue Type: Improvement Components: scripts and tools Affects Versions: 5.2.1 Reporter: Shawn Heisey Assignee: Shawn Heisey Fix For: 5.4 Attachments: SOLR-7880.patch, SOLR-7880.patch, SOLR-7880.patch While looking at SOLR-7847, I noticed that commons-cli was an old version, and once I upgraded it in the ivy config, found that SolrCLI is using deprecated classes/methods. This issue is to complete the upgrade and fix the deprecations. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7880) Update commons-cli to 1.3.1, fix usage of deprecated classes/methods
[ https://issues.apache.org/jira/browse/SOLR-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661284#comment-14661284 ] Shawn Heisey commented on SOLR-7880: For clarification, I was fixing warnings seen in Eclipse. I'm well aware that Eclipse warns on much more than javac does, but most of the time I think that it's worth fixing the IDE warnings as well as the compiler warnings, or suppressing them in certain situations. Update commons-cli to 1.3.1, fix usage of deprecated classes/methods Key: SOLR-7880 URL: https://issues.apache.org/jira/browse/SOLR-7880 Project: Solr Issue Type: Improvement Components: scripts and tools Affects Versions: 5.2.1 Reporter: Shawn Heisey Assignee: Shawn Heisey Fix For: 5.4 Attachments: SOLR-7880.patch, SOLR-7880.patch, SOLR-7880.patch While looking at SOLR-7847, I noticed that commons-cli was an old version, and once I upgraded it in the ivy config, found that SolrCLI is using deprecated classes/methods. This issue is to complete the upgrade and fix the deprecations. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7880) Update commons-cli to 1.3.1, fix usage of deprecated classes/methods
[ https://issues.apache.org/jira/browse/SOLR-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659138#comment-14659138 ] Shawn Heisey commented on SOLR-7880: As recommended by [~thelabdude], I will do more testing (especially on Windows) and make sure that I haven't missed any other usages of the commons-cli package. I don't know if it matters, but when I ran the tests that passed, I did so on Windows. I did the precommit on Linux, though -- I don't have all the prerequisites for that build target on my Windows machine. Update commons-cli to 1.3.1, fix usage of deprecated classes/methods Key: SOLR-7880 URL: https://issues.apache.org/jira/browse/SOLR-7880 Project: Solr Issue Type: Improvement Components: scripts and tools Affects Versions: 5.2.1 Reporter: Shawn Heisey Attachments: SOLR-7880.patch While looking at SOLR-7847, I noticed that commons-cli was an old version, and once I upgraded it in the ivy config, found that SolrCLI is using deprecated classes/methods. This issue is to complete the upgrade and fix the deprecations. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
