[jira] [Commented] (SOLR-8074) LoadAdminUIServlet directly references admin.html
[ https://issues.apache.org/jira/browse/SOLR-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971402#comment-14971402 ] ASF subversion and git services commented on SOLR-8074: --- Commit 1710271 from [~markrmil...@gmail.com] in branch 'dev/trunk' [ https://svn.apache.org/r1710271 ] SOLR-8074: LoadAdminUIServlet directly references admin.html > LoadAdminUIServlet directly references admin.html > - > > Key: SOLR-8074 > URL: https://issues.apache.org/jira/browse/SOLR-8074 > Project: Solr > Issue Type: Bug > Components: web gui >Reporter: Upayavira >Assignee: Mark Miller >Priority: Minor > Fix For: 5.4 > > Attachments: SOLR-8074.patch > > > The LoadAdminUIServlet class loads up, and serves back, "admin.html", meaning > it cannot be used in its current state to serve up the new admin UI. > An update is needed to this class to make it serve back whatever html file > was requested in the URL. There will, likely, only ever be two of them > mentioned in web.xml, but it would be really useful for changes to web.xml > not to require Java code changes also. > I'm hoping that someone with an up-and-running Java coding setup can make > this pretty trivial tweak. Any volunteers? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8074) LoadAdminUIServlet directly references admin.html
[ https://issues.apache.org/jira/browse/SOLR-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971407#comment-14971407 ] ASF subversion and git services commented on SOLR-8074: --- Commit 1710272 from [~markrmil...@gmail.com] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1710272 ] SOLR-8074: LoadAdminUIServlet directly references admin.html > LoadAdminUIServlet directly references admin.html > - > > Key: SOLR-8074 > URL: https://issues.apache.org/jira/browse/SOLR-8074 > Project: Solr > Issue Type: Bug > Components: web gui >Reporter: Upayavira >Assignee: Mark Miller >Priority: Minor > Fix For: 5.4 > > Attachments: SOLR-8074.patch > > > The LoadAdminUIServlet class loads up, and serves back, "admin.html", meaning > it cannot be used in its current state to serve up the new admin UI. > An update is needed to this class to make it serve back whatever html file > was requested in the URL. There will, likely, only ever be two of them > mentioned in web.xml, but it would be really useful for changes to web.xml > not to require Java code changes also. > I'm hoping that someone with an up-and-running Java coding setup can make > this pretty trivial tweak. Any volunteers? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8074) LoadAdminUIServlet directly references admin.html
[
https://issues.apache.org/jira/browse/SOLR-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968928#comment-14968928
]
Upayavira commented on SOLR-8074:
-
To add a little more detail:
The original admin UI is rendered by admin.html. web.xml causes this to be
served by the o.a.s.servlet.LoadAdminUIServlet, which does a few things like
replacing ${version} tags and setting anti-clickjacking headers.
Therefore, we need to also use this servlet to serve index.html, which is the
new UI.
However, this servlet includes this line:
InputStream in = getServletContext().getResourceAsStream("/admin.html");
This change is trivial - we just need to get from the request the actual URL
that was requested, rather than hardwired, and load that filename from disk.
Then I can add index.html to web.xml, and then we can make the new UI default
in trunk.
> LoadAdminUIServlet directly references admin.html
> -
>
> Key: SOLR-8074
> URL: https://issues.apache.org/jira/browse/SOLR-8074
> Project: Solr
> Issue Type: Bug
> Components: web gui
>Reporter: Upayavira
>Priority: Minor
> Fix For: 5.4
>
>
> The LoadAdminUIServlet class loads up, and serves back, "admin.html", meaning
> it cannot be used in its current state to serve up the new admin UI.
> An update is needed to this class to make it serve back whatever html file
> was requested in the URL. There will, likely, only ever be two of them
> mentioned in web.xml, but it would be really useful for changes to web.xml
> not to require Java code changes also.
> I'm hoping that someone with an up-and-running Java coding setup can make
> this pretty trivial tweak. Any volunteers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8074) LoadAdminUIServlet directly references admin.html
[ https://issues.apache.org/jira/browse/SOLR-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969399#comment-14969399 ] Upayavira commented on SOLR-8074: - Perfect. All I was asking for. Thx! > LoadAdminUIServlet directly references admin.html > - > > Key: SOLR-8074 > URL: https://issues.apache.org/jira/browse/SOLR-8074 > Project: Solr > Issue Type: Bug > Components: web gui >Reporter: Upayavira >Assignee: Mark Miller >Priority: Minor > Fix For: 5.4 > > Attachments: SOLR-8074.patch > > > The LoadAdminUIServlet class loads up, and serves back, "admin.html", meaning > it cannot be used in its current state to serve up the new admin UI. > An update is needed to this class to make it serve back whatever html file > was requested in the URL. There will, likely, only ever be two of them > mentioned in web.xml, but it would be really useful for changes to web.xml > not to require Java code changes also. > I'm hoping that someone with an up-and-running Java coding setup can make > this pretty trivial tweak. Any volunteers? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
