[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115289#comment-15115289
]
Joel Bernstein commented on SOLR-8519:
--
Ok, I'll take a look at this today.
> Implement
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115765#comment-15115765
]
Joel Bernstein commented on SOLR-8519:
--
Committed:
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115680#comment-15115680
]
Joel Bernstein commented on SOLR-8519:
--
The latest patch looks great! I don't plan on making any
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115681#comment-15115681
]
Kevin Risden commented on SOLR-8519:
[~joel.bernstein] - I opened a PR for this which has the same
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115717#comment-15115717
]
Joel Bernstein commented on SOLR-8519:
--
Actually that patches are working out well. Let's keep going
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115684#comment-15115684
]
Kevin Risden commented on SOLR-8519:
{quote}
As we start implementing the column type methods I think
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114655#comment-15114655
]
Joel Bernstein commented on SOLR-8519:
--
This is looking good.
> Implement
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114363#comment-15114363
]
Kevin Risden commented on SOLR-8519:
Hmmm I think that adding metadata to the first tuple could work.
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114353#comment-15114353
]
Joel Bernstein commented on SOLR-8519:
--
We can use this ticket to workout the git workflow. How does
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114366#comment-15114366
]
Kevin Risden commented on SOLR-8519:
I've been using git and creating patches previous to the git
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114432#comment-15114432
]
Joel Bernstein commented on SOLR-8519:
--
Only thing about #1 is that if there is an empty result set
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114439#comment-15114439
]
Joel Bernstein commented on SOLR-8519:
--
Ok let's go with #2 with an option to turn it off and on, the
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114428#comment-15114428
]
Joel Bernstein commented on SOLR-8519:
--
That's another option. If we add a header from the SQLHandler
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114437#comment-15114437
]
Kevin Risden commented on SOLR-8519:
I like #2 since then don't have to worry about conflicting field
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114459#comment-15114459
]
Joel Bernstein commented on SOLR-8519:
--
We can still use the approach of wrapping a MetaDataStream
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114462#comment-15114462
]
Kevin Risden commented on SOLR-8519:
Yea that sounds reasonable to me. The JdbcTests might not have to
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114204#comment-15114204
]
Joel Bernstein commented on SOLR-8519:
--
I was thinking about about having the SQLHandler populate the
[
https://issues.apache.org/jira/browse/SOLR-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088105#comment-15088105
]
Kevin Risden commented on SOLR-8519:
Requires ResultSetMetaDataImpl class from SOLR-8513 to be merged
18 matches
Mail list logo
