[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328028#comment-15328028
]
ASF GitHub Bot commented on SOLR-8744:
--
Github user dragonsinth closed the pull request at:
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326290#comment-15326290
]
ASF subversion and git services commented on SOLR-8744:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326247#comment-15326247
]
ASF subversion and git services commented on SOLR-8744:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326246#comment-15326246
]
ASF subversion and git services commented on SOLR-8744:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15325119#comment-15325119
]
Scott Blum commented on SOLR-8744:
--
That said, if you'd feel more comfortable committing your patch as-is,
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324928#comment-15324928
]
Scott Blum commented on SOLR-8744:
--
Attached a slightly modified patchfile with the changes I suggested.
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324896#comment-15324896
]
Scott Blum commented on SOLR-8744:
--
Also, add blockedTasks to printTrackingMaps()?
> Overseer operations
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324891#comment-15324891
]
Scott Blum commented on SOLR-8744:
--
LG. I only have one suggestion left, to formulate the "fetch" section
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324026#comment-15324026
]
Noble Paul commented on SOLR-8744:
--
That is true, they may not be necessarily blocked, They are
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324024#comment-15324024
]
Noble Paul commented on SOLR-8744:
--
I will have to beast this test and see if I can reproduce this
>
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324022#comment-15324022
]
Noble Paul commented on SOLR-8744:
--
Yes, but I'm not sure if it's worth. The other counts asnd assumptions
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323589#comment-15323589
]
ASF GitHub Bot commented on SOLR-8744:
--
Github user dragonsinth commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323478#comment-15323478
]
Scott Blum commented on SOLR-8744:
--
See second commit in https://github.com/apache/lucene-solr/pull/42
>
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323476#comment-15323476
]
ASF GitHub Bot commented on SOLR-8744:
--
GitHub user dragonsinth opened a pull request:
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323447#comment-15323447
]
Scott Blum commented on SOLR-8744:
--
One other comment:
{code}
// We are breaking out if we
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323436#comment-15323436
]
Scott Blum commented on SOLR-8744:
--
Actually, I may have a fix. You need a Thread.sleep() in the final
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323393#comment-15323393
]
Scott Blum commented on SOLR-8744:
--
I got one test failure patching this into master:
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323207#comment-15323207
]
Scott Blum commented on SOLR-8744:
--
BTW, I landed SOLR-9191 in master and 6x, so you should be good to go
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323205#comment-15323205
]
Scott Blum commented on SOLR-8744:
--
Mostly LG. One completely minor comment:
{code}
+ if
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319849#comment-15319849
]
Noble Paul commented on SOLR-8744:
--
Sure Scott. Let's commit that first. Let's make these two a blocker
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319289#comment-15319289
]
Scott Blum commented on SOLR-8744:
--
btw: mind if I land SOLR-9191 first? I will potentially need to
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319026#comment-15319026
]
Scott Blum commented on SOLR-8744:
--
Yeah 1000 seems totally reasonable. Beyond that, it seems kind of
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318967#comment-15318967
]
Noble Paul commented on SOLR-8744:
--
bq. think we need a cap on the total size of blockedTasks; otherwise
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318816#comment-15318816
]
Scott Blum commented on SOLR-8744:
--
Some quick feedback:
- I think we need a cap on the total size of
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317982#comment-15317982
]
Noble Paul commented on SOLR-8744:
--
We have another problem because of tasks which cannot be run because
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312017#comment-15312017
]
ASF subversion and git services commented on SOLR-8744:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312007#comment-15312007
]
ASF subversion and git services commented on SOLR-8744:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311583#comment-15311583
]
Noble Paul commented on SOLR-8744:
--
I'm planning to commit this soon
> Overseer operations need more fine
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311044#comment-15311044
]
Scott Blum commented on SOLR-8744:
--
Hi, any update on this! Seemed like it was really close.
> Overseer
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300417#comment-15300417
]
Scott Blum commented on SOLR-8744:
--
Good stuff, new LockTree looking good.
When does TaskBatch.batchId
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299479#comment-15299479
]
Noble Paul commented on SOLR-8744:
--
bq. One more big question for me: why does the LockTree need a
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298841#comment-15298841
]
Scott Blum commented on SOLR-8744:
--
Relatedly, lockTask should probably ensure that the appropriate number
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298839#comment-15298839
]
Scott Blum commented on SOLR-8744:
--
[~noble.paul] One more big question for me: why does the LockTree need
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298822#comment-15298822
]
Scott Blum commented on SOLR-8744:
--
Or make "OverseerLock" a top-level interface type in the package.
>
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298821#comment-15298821
]
Scott Blum commented on SOLR-8744:
--
[~noblepaul] One more comment, instead of making LockTree.LockObject
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298781#comment-15298781
]
David Smiley commented on SOLR-8744:
Maybe my ideas to simplify should really be its own issue because
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298756#comment-15298756
]
David Smiley commented on SOLR-8744:
bq. (Noble) David , It works. But it is not yet complete. But, I
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298486#comment-15298486
]
Noble Paul commented on SOLR-8744:
--
David , It works. But it is not yet complete. But, I miss the point.
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298482#comment-15298482
]
Scott Blum commented on SOLR-8744:
--
Have you run your impl against the test Noble Paul wrote? Curious if
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297771#comment-15297771
]
Noble Paul commented on SOLR-8744:
--
Thanks [~dsmiley]
The implementation is *wrong*
It's not enough to
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297713#comment-15297713
]
Noble Paul commented on SOLR-8744:
--
bq. Node would keep track of its parent only, not children.
I do not
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297710#comment-15297710
]
Noble Paul commented on SOLR-8744:
--
bq. In OverseerTaskProcessor, handing off the lock object (up to and
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297100#comment-15297100
]
Scott Blum commented on SOLR-8744:
--
Digging into the LockTree now to understand it better. Some
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297086#comment-15297086
]
David Smiley commented on SOLR-8744:
The main purpose of my suggestion is simplicity: LockTree
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296569#comment-15296569
]
Noble Paul commented on SOLR-8744:
--
Thanks [~dsmiley] for your comments
bq.which we only obtain a fixed
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296426#comment-15296426
]
David Smiley commented on SOLR-8744:
I looked over the patch just a little bit but the suggestion I'm
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295648#comment-15295648
]
Noble Paul commented on SOLR-8744:
--
Patch with tests . More testing required. But please review the class
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281187#comment-15281187
]
Scott Blum commented on SOLR-8744:
--
Good plan!
> Overseer operations need more fine grained mutual
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281175#comment-15281175
]
Noble Paul commented on SOLR-8744:
--
good question. Starvation is indeed a problem and we must make the
[
https://issues.apache.org/jira/browse/SOLR-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280534#comment-15280534
]
Scott Blum commented on SOLR-8744:
--
Design looks good to me.
One think to talk through, this may not be a
50 matches
Mail list logo
