[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350963#comment-15350963
]
Steve Rowe commented on SOLR-9027:
--
Reproducing NPE on {{TestGraphTermsQParserPlugin.testQueries()}}:
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266890#comment-15266890
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266798#comment-15266798
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266612#comment-15266612
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266611#comment-15266611
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266608#comment-15266608
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266610#comment-15266610
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264151#comment-15264151
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264124#comment-15264124
]
Joel Bernstein commented on SOLR-9027:
--
Yep, I see this. I'll make this change as well.
> Add
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264109#comment-15264109
]
David Smiley commented on SOLR-9027:
Nice [~joel.bernstein].
BTW about collectTermContext, to be more
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264097#comment-15264097
]
Joel Bernstein commented on SOLR-9027:
--
Ok, I moved the TermContext collection into createWeight, so
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264092#comment-15264092
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262856#comment-15262856
]
Joel Bernstein commented on SOLR-9027:
--
Good point, I may take one more pass at refactoring before
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262823#comment-15262823
]
David Smiley commented on SOLR-9027:
bq. I dug into how the TermContext is being used elsewhere in
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262580#comment-15262580
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262381#comment-15262381
]
Joel Bernstein commented on SOLR-9027:
--
[~dsmiley], I've been working on the changes you proposed. I
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261408#comment-15261408
]
Kevin Watters commented on SOLR-9027:
-
no specific use case.. but if doc frequency is 0 for a given
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261400#comment-15261400
]
Joel Bernstein commented on SOLR-9027:
--
Sure, this would be easy to add. I was having a hard time
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261311#comment-15261311
]
Kevin Watters commented on SOLR-9027:
-
Yes, sorry for the typo, minDocFreq :) avoid sparse edges ..
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261308#comment-15261308
]
Joel Bernstein commented on SOLR-9027:
--
Thanks!
The GraphTermsQuery has a maxDocFreq param, did you
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261007#comment-15261007
]
Kevin Watters commented on SOLR-9027:
-
Nice stuff Joel! Just a thought, it might be nice to also
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260228#comment-15260228
]
Joel Bernstein commented on SOLR-9027:
--
Ok, I'll do one more round of work on this in master before
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260169#comment-15260169
]
David Smiley commented on SOLR-9027:
Because this query is intentionally non-cacheable (unlike just
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260154#comment-15260154
]
Joel Bernstein commented on SOLR-9027:
--
[~dsmiley], I was looking at the TermContext issue that you
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260155#comment-15260155
]
Joel Bernstein commented on SOLR-9027:
--
Also thanks for reviewing!
> Add GraphTermsQuery to limit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260103#comment-15260103
]
Joel Bernstein commented on SOLR-9027:
--
Ok, I didn't realize that. So they must start from where they
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260065#comment-15260065
]
David Smiley commented on SOLR-9027:
Some TermsEnum impls, including the default one, are optimized for
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260053#comment-15260053
]
Joel Bernstein commented on SOLR-9027:
--
bq why wrap each BytesRef in a Term when in the end you just
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259548#comment-15259548
]
David Smiley commented on SOLR-9027:
I took a peek at what you committed out of curiosity.
* why wrap
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258857#comment-15258857
]
ASF subversion and git services commented on SOLR-9027:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254579#comment-15254579
]
Joel Bernstein commented on SOLR-9027:
--
Actually more tests have shown that I'm not collecting the
31 matches
Mail list logo
