[jira] [Commented] (SOLR-9483) Add SolrJ support for the modify collection API
[
https://issues.apache.org/jira/browse/SOLR-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088934#comment-16088934
]
Amrit Sarkar commented on SOLR-9483:
I extended and improved a bit the pulled request changes by
[~susheel2...@gmail.com] and put it in a patch like we are suppose to:
{code}
modified:
solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
modified:
solrj/src/test/org/apache/solr/client/solrj/CollectionAdminRequestRequiredParamsTest.java
{code}
Patch uploaded.
> Add SolrJ support for the modify collection API
> ---
>
> Key: SOLR-9483
> URL: https://issues.apache.org/jira/browse/SOLR-9483
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: clients - java, SolrCloud, SolrJ
>Reporter: Shalin Shekhar Mangar
> Labels: difficulty-easy, newdev
> Fix For: 7.0, 6.7
>
>
> SolrJ currently does not have a method corresponding to the modify collection
> API. There should be a Modify class inside CollectionAdminRequest and a
> simple method to change all parameters supported by the modify API.
> Link to modify API documentation:
> https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-modifycoll
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9483) Add SolrJ support for the modify collection API
[ https://issues.apache.org/jira/browse/SOLR-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087831#comment-16087831 ] Amrit Sarkar commented on SOLR-9483: [~shalinmangar] [~ichattopadhyaya] [~elyograg], Anyone working on this? If not, I can stretch this to conclusion. - Amrit Sarkar > Add SolrJ support for the modify collection API > --- > > Key: SOLR-9483 > URL: https://issues.apache.org/jira/browse/SOLR-9483 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrCloud, SolrJ >Reporter: Shalin Shekhar Mangar > Labels: difficulty-easy, newdev > Fix For: 7.0, 6.7 > > > SolrJ currently does not have a method corresponding to the modify collection > API. There should be a Modify class inside CollectionAdminRequest and a > simple method to change all parameters supported by the modify API. > Link to modify API documentation: > https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-modifycoll -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9483) Add SolrJ support for the modify collection API
[ https://issues.apache.org/jira/browse/SOLR-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907798#comment-15907798 ] Ishan Chattopadhyaya commented on SOLR-9483: Moving to 6.5, since 6.4 has already been released. > Add SolrJ support for the modify collection API > --- > > Key: SOLR-9483 > URL: https://issues.apache.org/jira/browse/SOLR-9483 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrCloud, SolrJ >Reporter: Shalin Shekhar Mangar > Labels: difficulty-easy, newdev > Fix For: 6.4, master (7.0) > > > SolrJ currently does not have a method corresponding to the modify collection > API. There should be a Modify class inside CollectionAdminRequest and a > simple method to change all parameters supported by the modify API. > Link to modify API documentation: > https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-modifycoll -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9483) Add SolrJ support for the modify collection API
[ https://issues.apache.org/jira/browse/SOLR-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585871#comment-15585871 ] Shalin Shekhar Mangar commented on SOLR-9483: - Since the time this issue was created, people have changed the solrj impl to favor methods like createCollection etc instead of a class for each API. So in keeping with the convention, a single modifyCollection method that can change all properties should be sufficient. > Add SolrJ support for the modify collection API > --- > > Key: SOLR-9483 > URL: https://issues.apache.org/jira/browse/SOLR-9483 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrCloud, SolrJ >Reporter: Shalin Shekhar Mangar > Labels: difficulty-easy, newdev > Fix For: 6.3, master (7.0) > > > SolrJ currently does not have a method corresponding to the modify collection > API. There should be a Modify class inside CollectionAdminRequest and a > simple method to change all parameters supported by the modify API. > Link to modify API documentation: > https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-modifycoll -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9483) Add SolrJ support for the modify collection API
[ https://issues.apache.org/jira/browse/SOLR-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585479#comment-15585479 ] Shawn Heisey commented on SOLR-9483: Regarding implementation choices: We've implemented a Builder pattern for SolrClient objects ... how insane would it be for us to do the same on Request objects? > Add SolrJ support for the modify collection API > --- > > Key: SOLR-9483 > URL: https://issues.apache.org/jira/browse/SOLR-9483 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrCloud, SolrJ >Reporter: Shalin Shekhar Mangar > Labels: difficulty-easy, newdev > Fix For: 6.3, master (7.0) > > > SolrJ currently does not have a method corresponding to the modify collection > API. There should be a Modify class inside CollectionAdminRequest and a > simple method to change all parameters supported by the modify API. > Link to modify API documentation: > https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-modifycoll -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9483) Add SolrJ support for the modify collection API
[ https://issues.apache.org/jira/browse/SOLR-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15582986#comment-15582986 ] Jacob Motley commented on SOLR-9483: Where is a good place to start to correctly add this method to CollectionAdminRequest? Are you asking for multiple "set" methods or something like a single method with the ability to change all of the attributes of the Collection it is called on? > Add SolrJ support for the modify collection API > --- > > Key: SOLR-9483 > URL: https://issues.apache.org/jira/browse/SOLR-9483 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrCloud, SolrJ >Reporter: Shalin Shekhar Mangar > Labels: difficulty-easy, newdev > Fix For: 6.3, master (7.0) > > > SolrJ currently does not have a method corresponding to the modify collection > API. There should be a Modify class inside CollectionAdminRequest and a > simple method to change all parameters supported by the modify API. > Link to modify API documentation: > https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-modifycoll -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
