[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807919#comment-15807919 ] ASF subversion and git services commented on SOLR-9928: --- Commit e275e91293e2ecb0356415a178c7ccd38a7182ff in lucene-solr's branch refs/heads/branch_6x from [~ab] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e275e91 ] SOLR-9928 Unwrap Directory consistently whenever it's passed as an argument. > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807415#comment-15807415 ] ASF subversion and git services commented on SOLR-9928: --- Commit e5f39f62f76677a5f500af4f323c0c31afb26228 in lucene-solr's branch refs/heads/master from [~ab] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e5f39f6 ] SOLR-9928 Unwrap Directory consistently whenever it's passed as an argument. > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[
https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807060#comment-15807060
]
Andrzej Bialecki commented on SOLR-9928:
-
bq. this factory tries to inject itself in an abnormal way, rather than
counting on being configured
That's exactly the intent. The reason for this design is that I wanted
consistency of adding the metrics monitoring no matter what implementation
users provided, and I couldn't count on metrics being injected in every
implementation (adding this functionality to base {{DirectoryFactory}} wouldn't
do it, because users would be free to create non-instrumented {{Directory}}
impls anyway).
So yes, it looks like we need to be consistent and unwrap this one level in
every call that takes {{Directory}} as argument.
> MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
>
>
> Key: SOLR-9928
> URL: https://issues.apache.org/jira/browse/SOLR-9928
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Affects Versions: master (7.0), 6.4
>Reporter: Mike Drob
>Assignee: Andrzej Bialecki
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9928.patch, SOLR-9928.patch
>
>
> MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead
> of super. Trivial patch forthcoming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805150#comment-15805150 ] Mark Miller commented on SOLR-9928: --- The argument for hiding and doing a single unwrap everywhere seems to be that this factory tries to inject itself in an abnormal way, rather than counting on being configured. It almost looks like it hides outside the cache - and so the unwrap would pass the cache key directory that impls may expect to get passed. > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805115#comment-15805115 ] Mark Miller commented on SOLR-9928: --- Previously non of the impls unwrapped more than One layer and they only did it for nrt caching dir. I recently fixed it so they unwrap Filtered dirs multiple layers. So we should remove the unwrapping probably. The consistency argument is that it's confusing to only do some Methods. It indicates the unwrapping is unnecessary cruft where it used. Or it's intentionally trying to hide the dir and failing to in some cases. Doesn't make sense in any scenario. > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804976#comment-15804976 ] Mike Drob commented on SOLR-9928: - Ran some tests locally and it looks like the only two specializations both unwrap properly internally, so we don't have to worry about it here. Needed to unwrap in renameWithOverwrite because the implementations there _did not_ unwrap before trying to use. I don't have strong opinions about the consistency argument here. However, while looking into this, I discovered a bug in StandardDirectoryFactory::move, filed as SOLR-9937 > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803494#comment-15803494 ] Mark Miller commented on SOLR-9928: --- Im not even sure the wrapping is needed. The impels should properly unwrap bow. But perhaps the Intent was to hide. In either case we should be consistent. > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803427#comment-15803427 ] Mike Drob commented on SOLR-9928: - Also, we can safely remove MetricsDirectory.getBaseDir since all implementations bubble up to DirectoryFactory anyway. > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803421#comment-15803421 ] Mike Drob commented on SOLR-9928: - We very possibly could need to unwrap for move, and haven't caught it because that only gets called in a very specific case to move specific files during a replication. I'll try to write up a test to hit this path. Note that we do already unwrap for remove, which makes me think you're on the right track. > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803208#comment-15803208 ] Mark Miller commented on SOLR-9928: --- Mostly I guess I'm looking at move. > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803205#comment-15803205 ] Mark Miller commented on SOLR-9928: --- Why do we unwrap in some methods that can get overridden but not others? > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802048#comment-15802048 ] Andrzej Bialecki commented on SOLR-9928: - Well spotted! Thank you for the patch - committed to master and branch_6x. > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802047#comment-15802047 ] ASF subversion and git services commented on SOLR-9928: --- Commit 60da846b14f4d7904db2b4ee74b4cea247c6c572 in lucene-solr's branch refs/heads/branch_6x from [~ab] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=60da846 ] SOLR-9928: MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super (Mike Drob via ab) > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9928) MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
[ https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15801834#comment-15801834 ] ASF subversion and git services commented on SOLR-9928: --- Commit e5264c48955165ac5c5b1aabba4748378d3f6fa9 in lucene-solr's branch refs/heads/master from [~ab] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e5264c4 ] SOLR-9928: MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super (Mike Drob via ab) > MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super > > > Key: SOLR-9928 > URL: https://issues.apache.org/jira/browse/SOLR-9928 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: master (7.0), 6.4 >Reporter: Mike Drob >Assignee: Andrzej Bialecki > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9928.patch, SOLR-9928.patch > > > MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead > of super. Trivial patch forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
