[jira] [Commented] (SOLR-9987) Implement support for multi-valued DocValues in PointFields
[ https://issues.apache.org/jira/browse/SOLR-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864458#comment-15864458 ] ASF subversion and git services commented on SOLR-9987: --- Commit 81b4288a2133dce87e0ac92da5f6e37dc28176f6 in lucene-solr's branch refs/heads/branch_6x from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=81b4288 ] SOLR-8396, SOLR-9987, SOLR-10011: Move CHANGES entries from 7.0 to 6.5 > Implement support for multi-valued DocValues in PointFields > --- > > Key: SOLR-9987 > URL: https://issues.apache.org/jira/browse/SOLR-9987 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Tomás Fernández Löbbe >Assignee: Tomás Fernández Löbbe > Attachments: SOLR-9987.patch, SOLR-9987.patch > > > This is not currently supported, and since PointFields can't use FieldCache, > faceting, stats, etc is not supported on multi-valued point fields. Followup > task of SOLR-8396 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9987) Implement support for multi-valued DocValues in PointFields
[ https://issues.apache.org/jira/browse/SOLR-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864454#comment-15864454 ] ASF subversion and git services commented on SOLR-9987: --- Commit bc10fa67b641d0cfb9bd1954378019d4fc343ae8 in lucene-solr's branch refs/heads/branch_6x from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bc10fa6 ] SOLR-9987: Implement support for multi-valued DocValues in PointFields CC SOLR-8396 > Implement support for multi-valued DocValues in PointFields > --- > > Key: SOLR-9987 > URL: https://issues.apache.org/jira/browse/SOLR-9987 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Tomás Fernández Löbbe >Assignee: Tomás Fernández Löbbe > Attachments: SOLR-9987.patch, SOLR-9987.patch > > > This is not currently supported, and since PointFields can't use FieldCache, > faceting, stats, etc is not supported on multi-valued point fields. Followup > task of SOLR-8396 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9987) Implement support for multi-valued DocValues in PointFields
[ https://issues.apache.org/jira/browse/SOLR-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864073#comment-15864073 ] ASF subversion and git services commented on SOLR-9987: --- Commit 7dcf9de41f6435a741910a6367ef9fece11a588b in lucene-solr's branch refs/heads/master from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7dcf9de ] SOLR-9987: Implement support for multi-valued DocValues in PointFields CC SOLR-8396 > Implement support for multi-valued DocValues in PointFields > --- > > Key: SOLR-9987 > URL: https://issues.apache.org/jira/browse/SOLR-9987 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Tomás Fernández Löbbe >Assignee: Tomás Fernández Löbbe > Attachments: SOLR-9987.patch, SOLR-9987.patch > > > This is not currently supported, and since PointFields can't use FieldCache, > faceting, stats, etc is not supported on multi-valued point fields. Followup > task of SOLR-8396 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9987) Implement support for multi-valued DocValues in PointFields
[ https://issues.apache.org/jira/browse/SOLR-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862636#comment-15862636 ] David Smiley commented on SOLR-9987: Ugh; ok. I was a watcher on SOLR-5260 but missed the implication. +1 to commit then. > Implement support for multi-valued DocValues in PointFields > --- > > Key: SOLR-9987 > URL: https://issues.apache.org/jira/browse/SOLR-9987 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Tomás Fernández Löbbe >Assignee: Tomás Fernández Löbbe > Attachments: SOLR-9987.patch, SOLR-9987.patch > > > This is not currently supported, and since PointFields can't use FieldCache, > faceting, stats, etc is not supported on multi-valued point fields. Followup > task of SOLR-8396 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9987) Implement support for multi-valued DocValues in PointFields
[
https://issues.apache.org/jira/browse/SOLR-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862490#comment-15862490
]
Tomás Fernández Löbbe commented on SOLR-9987:
-
Thanks for reviewing David. The issue is that {{facet.mincount=0}} doesn't work
currently (SOLR-10033), and it's not easy, since we don't have {{TermsEnum}}
for PointFields. So yes, if the user sets facet.mincount=0 in the request I'm
currently blindly changing it to 1, which is the same thing that happens today
with TrieFields that have indexed="false" and docValues="true" (since
SOLR-5260, before that we would throw an exception).
An extra issue is that currently by default in distributed facet requests,
shard requests are always set to {{facet.mincount=0}} (see SOLR-8988 and
SOLR-9152). I don't want to put this exception back until the defaults change.
> Implement support for multi-valued DocValues in PointFields
> ---
>
> Key: SOLR-9987
> URL: https://issues.apache.org/jira/browse/SOLR-9987
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Tomás Fernández Löbbe
>Assignee: Tomás Fernández Löbbe
> Attachments: SOLR-9987.patch, SOLR-9987.patch
>
>
> This is not currently supported, and since PointFields can't use FieldCache,
> faceting, stats, etc is not supported on multi-valued point fields. Followup
> task of SOLR-8396
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9987) Implement support for multi-valued DocValues in PointFields
[
https://issues.apache.org/jira/browse/SOLR-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862241#comment-15862241
]
David Smiley commented on SOLR-9987:
Wow you did a lot of work for this! Thanks for doing this work.
As I skimmed through with curiosity, one thing caught my eye:
{code}
+//We should do this, but mincount=0 is currently the default
+//if (ft.isPointField() && mincount <= 0) {
+// throw new SolrException(ErrorCode.BAD_REQUEST,
FacetParams.FACET_MINCOUNT + " <= 0 is not supported on point types");
+//}
{code}
Judging from this and nearby code changes, if minCount is 0 then you make it 1
instead (for PointFields only); is this right? This seems wrong to me. I
suspect we all agree that the default of 0 is unfortunate but ignoring it and
pretending it's not in certain cases but not others seems wrong. Instead, I
propose that we make the default '1' for 7.0. Obviously such a change would be
in another issue.
> Implement support for multi-valued DocValues in PointFields
> ---
>
> Key: SOLR-9987
> URL: https://issues.apache.org/jira/browse/SOLR-9987
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Tomás Fernández Löbbe
>Assignee: Tomás Fernández Löbbe
> Attachments: SOLR-9987.patch, SOLR-9987.patch
>
>
> This is not currently supported, and since PointFields can't use FieldCache,
> faceting, stats, etc is not supported on multi-valued point fields. Followup
> task of SOLR-8396
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9987) Implement support for multi-valued DocValues in PointFields
[
https://issues.apache.org/jira/browse/SOLR-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829169#comment-15829169
]
Tomás Fernández Löbbe commented on SOLR-9987:
-
As discussed in SOLR-8396, we should use {{SortedNumericDocValues}}. There are
already some (ignored) tests in {{TestPointFields}} for this feature, once it's
available.
> Implement support for multi-valued DocValues in PointFields
> ---
>
> Key: SOLR-9987
> URL: https://issues.apache.org/jira/browse/SOLR-9987
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Tomás Fernández Löbbe
>
> This is not currently supported, and since PointFields can't use FieldCache,
> faceting, stats, etc is not supported on multi-valued point fields. Followup
> task of SOLR-8396
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
