Dawid Weiss created LUCENE-8221: ----------------------------------- Summary: MoreLikeThis.setMaxDocFreqPct can easily int-overflow on larger indexes Key: LUCENE-8221 URL: https://issues.apache.org/jira/browse/LUCENE-8221 Project: Lucene - Core Issue Type: Bug Reporter: Dawid Weiss Assignee: Dawid Weiss
{code} public void setMaxDocFreqPct(int maxPercentage) { this.maxDocFreq = maxPercentage * ir.numDocs() / 100; } {code} The above overflows integer range into negative numbers on even fairly small indexes (for maxPercentage = 75, it happens for just over 28 million documents. We should make the computations on long range so that it doesn't overflow and have a more strict argument validation. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org