[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Male updated LUCENE-4165: --- Fix Version/s: 5.0 4.0 3.6.1 HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed -- Key: LUCENE-4165 URL: https://issues.apache.org/jira/browse/LUCENE-4165 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Affects Versions: 3.6 Environment: Linux, Java 1.6 Reporter: Torsten Krah Priority: Minor Fix For: 3.6.1, 4.0, 5.0 Attachments: LUCENE-4156-trunk.patch, LUCENE_4156_36.patch, lucene_36.patch, lucene_trunk.patch The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries. Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already. Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so). The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile(). So the question here is - have i have to close the streams myself after instantiating the dictionary? Or is the close call only missing for the dictionary streams? Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Krah updated LUCENE-4165: - Attachment: LUCENE_4156_36.patch Updated patch for 36 branch which does handle StemFactory closing. Ported IOUtils change from trunk to branch (IOException removed from throws declaration). HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed -- Key: LUCENE-4165 URL: https://issues.apache.org/jira/browse/LUCENE-4165 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Affects Versions: 3.6 Environment: Linux, Java 1.6 Reporter: Torsten Krah Priority: Minor Attachments: LUCENE-4156-trunk.patch, LUCENE_4156_36.patch, lucene_36.patch, lucene_trunk.patch The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries. Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already. Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so). The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile(). So the question here is - have i have to close the streams myself after instantiating the dictionary? Or is the close call only missing for the dictionary streams? Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Krah updated LUCENE-4165: - Attachment: LUCENE_4156_36.patch Updated patch, removed IOUtils change, catch useless Exception. HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed -- Key: LUCENE-4165 URL: https://issues.apache.org/jira/browse/LUCENE-4165 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Affects Versions: 3.6 Environment: Linux, Java 1.6 Reporter: Torsten Krah Priority: Minor Attachments: LUCENE-4156-trunk.patch, LUCENE_4156_36.patch, lucene_36.patch, lucene_trunk.patch The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries. Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already. Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so). The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile(). So the question here is - have i have to close the streams myself after instantiating the dictionary? Or is the close call only missing for the dictionary streams? Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Krah updated LUCENE-4165: - Attachment: (was: LUCENE_4156_36.patch) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed -- Key: LUCENE-4165 URL: https://issues.apache.org/jira/browse/LUCENE-4165 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Affects Versions: 3.6 Environment: Linux, Java 1.6 Reporter: Torsten Krah Priority: Minor Attachments: LUCENE-4156-trunk.patch, LUCENE_4156_36.patch, lucene_36.patch, lucene_trunk.patch The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries. Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already. Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so). The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile(). So the question here is - have i have to close the streams myself after instantiating the dictionary? Or is the close call only missing for the dictionary streams? Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Krah updated LUCENE-4165: - Attachment: lucene_36.patch lucene_trunk.patch Updated patches: 1. removed reader.close() call in readAffixFile() function. 2. Add comment at ctors and arguments to make clear that caller has to close the streams and that the ctor does not close them. 3. Test modified to check its actually not closed. 4. Added 2 close calls on the streams in trunk patch for the Test. HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed -- Key: LUCENE-4165 URL: https://issues.apache.org/jira/browse/LUCENE-4165 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Affects Versions: 3.6 Environment: Linux, Java 1.6 Reporter: Torsten Krah Priority: Minor Attachments: lucene_36.patch, lucene_36.patch, lucene_trunk.patch, lucene_trunk.patch The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries. Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already. Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so). The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile(). So the question here is - have i have to close the streams myself after instantiating the dictionary? Or is the close call only missing for the dictionary streams? Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Krah updated LUCENE-4165: - Attachment: (was: lucene_trunk.patch) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed -- Key: LUCENE-4165 URL: https://issues.apache.org/jira/browse/LUCENE-4165 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Affects Versions: 3.6 Environment: Linux, Java 1.6 Reporter: Torsten Krah Priority: Minor Attachments: lucene_36.patch, lucene_trunk.patch The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries. Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already. Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so). The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile(). So the question here is - have i have to close the streams myself after instantiating the dictionary? Or is the close call only missing for the dictionary streams? Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Krah updated LUCENE-4165: - Attachment: (was: lucene_36.patch) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed -- Key: LUCENE-4165 URL: https://issues.apache.org/jira/browse/LUCENE-4165 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Affects Versions: 3.6 Environment: Linux, Java 1.6 Reporter: Torsten Krah Priority: Minor Attachments: lucene_36.patch, lucene_trunk.patch The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries. Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already. Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so). The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile(). So the question here is - have i have to close the streams myself after instantiating the dictionary? Or is the close call only missing for the dictionary streams? Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Male updated LUCENE-4165: --- Attachment: LUCENE-4156-trunk.patch Updated version of trunk patch which closes the InputStreams created in Solr's HunspellStemFilterFactory. HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed -- Key: LUCENE-4165 URL: https://issues.apache.org/jira/browse/LUCENE-4165 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Affects Versions: 3.6 Environment: Linux, Java 1.6 Reporter: Torsten Krah Priority: Minor Attachments: LUCENE-4156-trunk.patch, lucene_36.patch, lucene_trunk.patch The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries. Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already. Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so). The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile(). So the question here is - have i have to close the streams myself after instantiating the dictionary? Or is the close call only missing for the dictionary streams? Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4165) HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed
[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Krah updated LUCENE-4165: - Attachment: lucene_36.patch lucene_trunk.patch - Patch against trunk and 3.6. - Resources are closed asap. - Finally block in constructor added to be sure resources are closed too if an exception is hit before resources are processed. - Test modified to check if close() was called on the provided streams after the Dictionary constructor was called. HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed -- Key: LUCENE-4165 URL: https://issues.apache.org/jira/browse/LUCENE-4165 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Affects Versions: 3.6 Environment: Linux, Java 1.6 Reporter: Torsten Krah Priority: Minor Attachments: lucene_36.patch, lucene_trunk.patch The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries. Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already. Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so). The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile(). So the question here is - have i have to close the streams myself after instantiating the dictionary? Or is the close call only missing for the dictionary streams? Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
