[jira] [Updated] (LUCENE-4896) PostingsHighlighter should use a interface of PassageFormatter instead of a class
[ https://issues.apache.org/jira/browse/LUCENE-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Cavanna updated LUCENE-4896: - Attachment: LUCENE-4896.patch No problem. It just felt weird to write an abstract class that looked to me like an interface. Should be better now. I also made append protected. PostingsHighlighter should use a interface of PassageFormatter instead of a class - Key: LUCENE-4896 URL: https://issues.apache.org/jira/browse/LUCENE-4896 Project: Lucene - Core Issue Type: Improvement Components: modules/highlighter Affects Versions: 4.2 Environment: NA Reporter: Sebastien Dionne Labels: newdev Attachments: LUCENE-4896.patch, LUCENE-4896.patch In my project I need a custom PassageFormatter to use with PostingsHighlighter. I extended PassageFormatter to override format(...) but if I do that, I don't have access to the private variables. So instead of changing the scope to protected, it should be more usefull to use a interface for PassageFormatter. like public DefaultPassageFormatter implements PassageFormatter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4896) PostingsHighlighter should use a interface of PassageFormatter instead of a class
[ https://issues.apache.org/jira/browse/LUCENE-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Cavanna updated LUCENE-4896: - Attachment: LUCENE-4896.patch Here it is. The lucene.experimental was already there, I left it only in the abstract class. Fixed format javadocs too. PostingsHighlighter should use a interface of PassageFormatter instead of a class - Key: LUCENE-4896 URL: https://issues.apache.org/jira/browse/LUCENE-4896 Project: Lucene - Core Issue Type: Improvement Components: modules/highlighter Affects Versions: 4.2 Environment: NA Reporter: Sebastien Dionne Labels: newdev Attachments: LUCENE-4896.patch, LUCENE-4896.patch, LUCENE-4896.patch In my project I need a custom PassageFormatter to use with PostingsHighlighter. I extended PassageFormatter to override format(...) but if I do that, I don't have access to the private variables. So instead of changing the scope to protected, it should be more usefull to use a interface for PassageFormatter. like public DefaultPassageFormatter implements PassageFormatter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-4896) PostingsHighlighter should use a interface of PassageFormatter instead of a class
[ https://issues.apache.org/jira/browse/LUCENE-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-4896: Labels: newdev (was: ) PostingsHighlighter should use a interface of PassageFormatter instead of a class - Key: LUCENE-4896 URL: https://issues.apache.org/jira/browse/LUCENE-4896 Project: Lucene - Core Issue Type: Improvement Components: modules/highlighter Affects Versions: 4.2 Environment: NA Reporter: Sebastien Dionne Labels: newdev In my project I need a custom PassageFormatter to use with PostingsHighlighter. I extended PassageFormatter to override format(...) but if I do that, I don't have access to the private variables. So instead of changing the scope to protected, it should be more usefull to use a interface for PassageFormatter. like public DefaultPassageFormatter implements PassageFormatter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org