[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: SOLR-10235.patch
New patch.
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch, SOLR-10235.patch,
> SOLR-10235.patch, SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: (was: SOLR-10235.patch)
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch, SOLR-10235.patch,
> SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: SOLR-10235.patch
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch, SOLR-10235.patch,
> SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: SOLR-10235.patch
Sorry for posting so many patches. I reimplemented the Driver interface without
mocks. This ensures that it will also work with later Java versions. It will
return a version number and properties (if the DriverManager requires that
metainformation), but return the mocked Connection instance, if the URL matches.
I think that's ready now.
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch, SOLR-10235.patch,
> SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: SOLR-10235.patch
I changed the Driver a bit to only work on its "supported URL" (a ststic final
String). This ensure that we do not pollute the JVM with a driver that "owns"
every URL.
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch, SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: (was: SOLR-10235.patch)
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: SOLR-10235.patch
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: (was: SOLR-10235.patch)
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: SOLR-10235.patch
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-10235:
-
Attachment: SOLR-10235.patch
Here is a fixed patch. Actually I now understand the problem: JdbcDataSource
tries to instantiate the class and create an instance if the driver is not
already registered. But as the driver is registered manually before usage in
our code, we don't want to have this. Because of this I added an empty ctor to
disallow this. For "registering" the driver, we pass our mock connection to the
driver and it passes.
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9
[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-10235:
Attachment: SOLR-10235.patch
Attaching a patch showing what i had in mind.
seems to work fine with both java8 & java9.
[~thetaphi] & [~caomanhdat]: do you guys see any problems with this type of
approach?
> fix last TestJdbcDataSource / mock issue with java9
> ---
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
