[
https://issues.apache.org/jira/browse/LUCENE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006673#comment-13006673
]
Uwe Schindler commented on LUCENE-2944:
---
Looks fine, will do closer review tomorrow
[
https://issues.apache.org/jira/browse/LUCENE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006650#comment-13006650
]
Michael McCandless commented on LUCENE-2944:
Patch looks good!
> BytesRef re
[
https://issues.apache.org/jira/browse/LUCENE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006559#comment-13006559
]
Uwe Schindler commented on LUCENE-2944:
---
bq. How about .fillBytesRef() (returns has
[
https://issues.apache.org/jira/browse/LUCENE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006548#comment-13006548
]
Michael McCandless commented on LUCENE-2944:
How about .fillBytesRef() (retur
[
https://issues.apache.org/jira/browse/LUCENE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006192#comment-13006192
]
Simon Willnauer commented on LUCENE-2944:
-
I had a brief review - naming looks go
[
https://issues.apache.org/jira/browse/LUCENE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006188#comment-13006188
]
Robert Muir commented on LUCENE-2944:
-
guys, any comments on the api?
I am no good a
[
https://issues.apache.org/jira/browse/LUCENE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000930#comment-13000930
]
Michael McCandless commented on LUCENE-2944:
I think producer should own the
[
https://issues.apache.org/jira/browse/LUCENE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000915#comment-13000915
]
Robert Muir commented on LUCENE-2944:
-
Well its not just the ICU implementation... Te
[
https://issues.apache.org/jira/browse/LUCENE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000913#comment-13000913
]
Simon Willnauer commented on LUCENE-2944:
-
IMO this is ICUs problem here. This co
