A little nit: TokenStream.end() throws an IOException but does not need to

2013-10-20 Thread Lance Norskog
org.apache.lucene.analysis.TokenStream.end() public void end() throws IOException { clearAttributes(); // LUCENE-3849: don't consume dirty atts if (hasAttribute(PositionIncrementAttribute.class)) { getAttribute(PositionIncrementAttribute.class).setPositionIncrement(0); } } This

Re: A little nit: TokenStream.end() throws an IOException but does not need to

2013-10-20 Thread Robert Muir
It does need to. This allows a superclass to throw exception. On Sun, Oct 20, 2013 at 9:58 PM, Lance Norskog goks...@gmail.com wrote: org.apache.lucene.analysis.TokenStream.end() public void end() throws IOException { clearAttributes(); // LUCENE-3849: don't consume dirty atts if