Re: Cleaning up the code

2018-02-09 Thread Erick Erickson
Weekends are when I might be devoting some time to this Are there any more granular ways to suppress some warnings than at the method level? We have lots of places where we, say, open a SolrCore and don't close it, it's added to a list and closed later which is correct behavior so needs to be

Re: Cleaning up the code

2018-02-01 Thread Erick Erickson
Great, thanks! Half the battle is often knowing it's possible On Thu, Feb 1, 2018 at 10:48 AM, Robert Muir wrote: > Yes it is important to do it incrementally. > > You can override ant properties in specific modules, by defining them > to be something stricter before

Re: Cleaning up the code

2018-02-01 Thread Robert Muir
Yes it is important to do it incrementally. You can override ant properties in specific modules, by defining them to be something stricter before importing them from somewhere else. For example, analysis/icu has no warnings, so override the default javac.args at the very top, before it "imports"

Cleaning up the code

2018-02-01 Thread Erick Erickson
You've seen a couple of JIRAs about cleaning up precommit lint warnings, and Robert mentioned compiler warnings which I totally agree with. It's just a _lot_ of code to wade through, and it'll be depressing to fix up something and have similar stuff creep back in. It'll take quite some time to