RE: Policeman Jenkins lost it's "/view/Lucene-Solr/"
Exactly,
in Zookeeper alls paths are forward slashes (as it is a "path" inside the
zookeeper environment). If you replace that with a NIO Windows Path it creates
backslashes. This makes Zookeeper fail (of course).
Actually using the Hadoop class is broken workaround, it may be better to use
the java.net.URI class for correct "path" transformations. The risk with
java.nio.file.Path is also that if the path exists in file system it handles
the resolving different. So if some user has for some reason a local path
exactly looking like a zookeper node path it would use different behaviour.
So my suggestion: Use java.net.URI to build the path and use URI.getPath() or
similar to make a String out of it. The alternative to replace all backslashes
in the path to forwards slashes is a bad idea for the reasons I explained
before.
BTW, Windows is happy again!
Uwe
-
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Erick Erickson
> Sent: Thursday, July 16, 2020 1:40 AM
> To: dev@lucene.apache.org
> Subject: Re: Policeman Jenkins lost it's "/view/Lucene-Solr/"
>
> Let me try something. In the “you’ve got to be joking” category. Tell me you
> wouldn’t have made the same mistake ;)
>
> In several places:
>
> String parent = new Path(leaderPath).getParent().toString();
>
> was replaced with:
>
> String parent = Paths.get(leaderPath).getParent().toString();
>
> BUT, the new Path bit is actually a in org.apache.hadoop.fs that has lines
> like:
>
> if (hasWindowsDrive(pathString) && pathString.charAt(0) != '/') {
> pathString = "/" + pathString;
> }
>
> And a number of the erorrs are about how “blah doesn’t begin with /“.
>
> I’ll fix this and push and we’ll see. If that’s not it, we should revert but
> we won’t
> know until tomorrow.
>
> Erick
>
> > On Jul 15, 2020, at 11:27 AM, Uwe Schindler wrote:
> >
> > RoutingToNodesWithPropertiesTest
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: Policeman Jenkins lost it's "/view/Lucene-Solr/"
Let me try something. In the “you’ve got to be joking” category. Tell me you
wouldn’t have made the same mistake ;)
In several places:
String parent = new Path(leaderPath).getParent().toString();
was replaced with:
String parent = Paths.get(leaderPath).getParent().toString();
BUT, the new Path bit is actually a in org.apache.hadoop.fs that has lines like:
if (hasWindowsDrive(pathString) && pathString.charAt(0) != '/') {
pathString = "/" + pathString;
}
And a number of the erorrs are about how “blah doesn’t begin with /“.
I’ll fix this and push and we’ll see. If that’s not it, we should revert but we
won’t know until tomorrow.
Erick
> On Jul 15, 2020, at 11:27 AM, Uwe Schindler wrote:
>
> RoutingToNodesWithPropertiesTest
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
RE: Policeman Jenkins lost it's "/view/Lucene-Solr/"
It looks like the disk full behaviour on Windows is caused by the commit of https://issues.apache.org/jira/browse/SOLR-13939 We should revert this. - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Uwe Schindler > Sent: Wednesday, July 15, 2020 5:27 PM > To: dev@lucene.apache.org > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > This job was a new checkout (the first one after the cleanup). Again it > filled up > the disk: > > https://jenkins.thetaphi.de/job/Lucene-Solr-master- > Windows/9096/consoleText > Search for: "There is not enough space on the disk" > > It looks like it's caused by Test: > org.apache.solr.cloud.RoutingToNodesWithPropertiesTest (It happens during > "repro" of test failures at end of build) > > - > Uwe Schindler > Achterdiek 19, D-28357 Bremen > https://www.thetaphi.de > eMail: u...@thetaphi.de > > > -Original Message- > > From: Uwe Schindler > > Sent: Wednesday, July 15, 2020 5:17 PM > > To: dev@lucene.apache.org > > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > > Hi, > > > > some job again filled all of the disk. There seems to be a bug on Solr tests > > running on Windows so that it fills all remaining space on disk (18 > > Gigabytes). > > > > Uwe > > > > - > > Uwe Schindler > > Achterdiek 19, D-28357 Bremen > > https://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > > -Original Message- > > > From: Uwe Schindler > > > Sent: Tuesday, July 14, 2020 8:07 AM > > > To: 'Chris Hostetter' > > > Cc: dev@lucene.apache.org > > > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > > > > Hrm, > > > > > > Windows box had a Lucene-Master workspace of 18 Gigabytes Looks like > > > some test has blown up itsself. > > > > > > Uwe > > > > > > - > > > Uwe Schindler > > > Achterdiek 19, D-28357 Bremen > > > https://www.thetaphi.de > > > eMail: u...@thetaphi.de > > > > > > > -Original Message- > > > > From: Chris Hostetter > > > > Sent: Monday, July 13, 2020 6:27 PM > > > > To: Uwe Schindler > > > > Cc: Lucene Dev > > > > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > > > > > > > > > > : it seem to got lost on last Update. I was on vacation last week, so > > > > missed > > > your > > > > mail. > > > > : > > > > : I added it back, > > > > > > > > thanks! ... also: based on the recent jenkins emails it looks like your > > > > disk is full? > > > > > > > > (welcome back!) > > > > > > > > : Uwe > > > > : > > > > : - > > > > : Uwe Schindler > > > > : Achterdiek 19, D-28357 Bremen > > > > : https://www.thetaphi.de > > > > : eMail: u...@thetaphi.de > > > > : > > > > : > -Original Message- > > > > : > From: Chris Hostetter > > > > : > Sent: Monday, July 13, 2020 6:05 PM > > > > : > To: Uwe Schindler > > > > : > Cc: Lucene Dev > > > > : > Subject: Re: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > > : > > > > > : > > > > > : > Uwe? ... you around? can you please re-add this jenkins view? > > > > : > > > > > : > : Date: Thu, 2 Jul 2020 17:36:25 -0700 (MST) > > > > : > : From: Chris Hostetter > > > > : > : To: Uwe Schindler > > > > : > : Cc: Lucene Dev > > > > : > : Subject: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > > : > : > > > > : > : > > > > : > : Uwe: the "/view/Lucene-Solr/" View that my reports were using to > > > restrict > > > > the > > > > : > : jobs it checked on your jenkins server (to only lucene/solr jobs) > > > > seems > > to > > > > : > : have been removed... > > > > : > : > > > > : > : https://jenkins.thetaphi.de/view/Lucene-Solr/ > > > > : > : > > > > : > : ...as a result, my reports evidently haven't detected any > > > > failures (or > >
RE: Policeman Jenkins lost it's "/view/Lucene-Solr/"
This job was a new checkout (the first one after the cleanup). Again it filled up the disk: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Windows/9096/consoleText Search for: "There is not enough space on the disk" It looks like it's caused by Test: org.apache.solr.cloud.RoutingToNodesWithPropertiesTest (It happens during "repro" of test failures at end of build) - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Uwe Schindler > Sent: Wednesday, July 15, 2020 5:17 PM > To: dev@lucene.apache.org > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > Hi, > > some job again filled all of the disk. There seems to be a bug on Solr tests > running on Windows so that it fills all remaining space on disk (18 > Gigabytes). > > Uwe > > - > Uwe Schindler > Achterdiek 19, D-28357 Bremen > https://www.thetaphi.de > eMail: u...@thetaphi.de > > > -Original Message- > > From: Uwe Schindler > > Sent: Tuesday, July 14, 2020 8:07 AM > > To: 'Chris Hostetter' > > Cc: dev@lucene.apache.org > > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > > Hrm, > > > > Windows box had a Lucene-Master workspace of 18 Gigabytes Looks like > > some test has blown up itsself. > > > > Uwe > > > > - > > Uwe Schindler > > Achterdiek 19, D-28357 Bremen > > https://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > > -Original Message- > > > From: Chris Hostetter > > > Sent: Monday, July 13, 2020 6:27 PM > > > To: Uwe Schindler > > > Cc: Lucene Dev > > > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > > > > > > > : it seem to got lost on last Update. I was on vacation last week, so > > > missed > > your > > > mail. > > > : > > > : I added it back, > > > > > > thanks! ... also: based on the recent jenkins emails it looks like your > > > disk is full? > > > > > > (welcome back!) > > > > > > : Uwe > > > : > > > : - > > > : Uwe Schindler > > > : Achterdiek 19, D-28357 Bremen > > > : https://www.thetaphi.de > > > : eMail: u...@thetaphi.de > > > : > > > : > -Original Message----- > > > : > From: Chris Hostetter > > > : > Sent: Monday, July 13, 2020 6:05 PM > > > : > To: Uwe Schindler > > > : > Cc: Lucene Dev > > > : > Subject: Re: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > : > > > > : > > > > : > Uwe? ... you around? can you please re-add this jenkins view? > > > : > > > > : > : Date: Thu, 2 Jul 2020 17:36:25 -0700 (MST) > > > : > : From: Chris Hostetter > > > : > : To: Uwe Schindler > > > : > : Cc: Lucene Dev > > > : > : Subject: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > : > : > > > : > : > > > : > : Uwe: the "/view/Lucene-Solr/" View that my reports were using to > > restrict > > > the > > > : > : jobs it checked on your jenkins server (to only lucene/solr jobs) > > > seems > to > > > : > : have been removed... > > > : > : > > > : > : https://jenkins.thetaphi.de/view/Lucene-Solr/ > > > : > : > > > : > : ...as a result, my reports evidently haven't detected any failures > > > (or > > > : > : successes) from your jenkins jobs in a while... > > > : > : > > > : > : http://fucit.org/solr-jenkins-reports/ > > > : > : > > > : > : ...can you please add that view back? > > > : > : > > > : > : > > > : > : -Hoss > > > : > : http://www.lucidworks.com/ > > > : > : > > > : > > > > : > -Hoss > > > : > http://www.lucidworks.com/ > > > : > > > : > > > > > > -Hoss > > > http://www.lucidworks.com/ > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > > For additional commands, e-mail: dev-h...@lucene.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
RE: Policeman Jenkins lost it's "/view/Lucene-Solr/"
Hi, some job again filled all of the disk. There seems to be a bug on Solr tests running on Windows so that it fills all remaining space on disk (18 Gigabytes). Uwe - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Uwe Schindler > Sent: Tuesday, July 14, 2020 8:07 AM > To: 'Chris Hostetter' > Cc: dev@lucene.apache.org > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > Hrm, > > Windows box had a Lucene-Master workspace of 18 Gigabytes Looks like > some test has blown up itsself. > > Uwe > > - > Uwe Schindler > Achterdiek 19, D-28357 Bremen > https://www.thetaphi.de > eMail: u...@thetaphi.de > > > -Original Message- > > From: Chris Hostetter > > Sent: Monday, July 13, 2020 6:27 PM > > To: Uwe Schindler > > Cc: Lucene Dev > > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > > > > : it seem to got lost on last Update. I was on vacation last week, so missed > your > > mail. > > : > > : I added it back, > > > > thanks! ... also: based on the recent jenkins emails it looks like your > > disk is full? > > > > (welcome back!) > > > > : Uwe > > : > > : - > > : Uwe Schindler > > : Achterdiek 19, D-28357 Bremen > > : https://www.thetaphi.de > > : eMail: u...@thetaphi.de > > : > > : > -Original Message- > > : > From: Chris Hostetter > > : > Sent: Monday, July 13, 2020 6:05 PM > > : > To: Uwe Schindler > > : > Cc: Lucene Dev > > : > Subject: Re: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > : > > > : > > > : > Uwe? ... you around? can you please re-add this jenkins view? > > : > > > : > : Date: Thu, 2 Jul 2020 17:36:25 -0700 (MST) > > : > : From: Chris Hostetter > > : > : To: Uwe Schindler > > : > : Cc: Lucene Dev > > : > : Subject: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > : > : > > : > : > > : > : Uwe: the "/view/Lucene-Solr/" View that my reports were using to > restrict > > the > > : > : jobs it checked on your jenkins server (to only lucene/solr jobs) > > seems to > > : > : have been removed... > > : > : > > : > : https://jenkins.thetaphi.de/view/Lucene-Solr/ > > : > : > > : > : ...as a result, my reports evidently haven't detected any failures (or > > : > : successes) from your jenkins jobs in a while... > > : > : > > : > : http://fucit.org/solr-jenkins-reports/ > > : > : > > : > : ...can you please add that view back? > > : > : > > : > : > > : > : -Hoss > > : > : http://www.lucidworks.com/ > > : > : > > : > > > : > -Hoss > > : > http://www.lucidworks.com/ > > : > > : > > > > -Hoss > > http://www.lucidworks.com/ > > > - > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
RE: Policeman Jenkins lost it's "/view/Lucene-Solr/"
Hrm, Windows box had a Lucene-Master workspace of 18 Gigabytes Looks like some test has blown up itsself. Uwe - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Chris Hostetter > Sent: Monday, July 13, 2020 6:27 PM > To: Uwe Schindler > Cc: Lucene Dev > Subject: RE: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > : it seem to got lost on last Update. I was on vacation last week, so missed > your > mail. > : > : I added it back, > > thanks! ... also: based on the recent jenkins emails it looks like your > disk is full? > > (welcome back!) > > : Uwe > : > : - > : Uwe Schindler > : Achterdiek 19, D-28357 Bremen > : https://www.thetaphi.de > : eMail: u...@thetaphi.de > : > : > -Original Message- > : > From: Chris Hostetter > : > Sent: Monday, July 13, 2020 6:05 PM > : > To: Uwe Schindler > : > Cc: Lucene Dev > : > Subject: Re: Policeman Jenkins lost it's "/view/Lucene-Solr/" > : > > : > > : > Uwe? ... you around? can you please re-add this jenkins view? > : > > : > : Date: Thu, 2 Jul 2020 17:36:25 -0700 (MST) > : > : From: Chris Hostetter > : > : To: Uwe Schindler > : > : Cc: Lucene Dev > : > : Subject: Policeman Jenkins lost it's "/view/Lucene-Solr/" > : > : > : > : > : > : Uwe: the "/view/Lucene-Solr/" View that my reports were using to > restrict > the > : > : jobs it checked on your jenkins server (to only lucene/solr jobs) seems > to > : > : have been removed... > : > : > : > : https://jenkins.thetaphi.de/view/Lucene-Solr/ > : > : > : > : ...as a result, my reports evidently haven't detected any failures (or > : > : successes) from your jenkins jobs in a while... > : > : > : > : http://fucit.org/solr-jenkins-reports/ > : > : > : > : ...can you please add that view back? > : > : > : > : > : > : -Hoss > : > : http://www.lucidworks.com/ > : > : > : > > : > -Hoss > : > http://www.lucidworks.com/ > : > : > > -Hoss > http://www.lucidworks.com/ - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
RE: Policeman Jenkins lost it's "/view/Lucene-Solr/"
: it seem to got lost on last Update. I was on vacation last week, so missed your mail. : : I added it back, thanks! ... also: based on the recent jenkins emails it looks like your disk is full? (welcome back!) : Uwe : : - : Uwe Schindler : Achterdiek 19, D-28357 Bremen : https://www.thetaphi.de : eMail: u...@thetaphi.de : : > -Original Message- : > From: Chris Hostetter : > Sent: Monday, July 13, 2020 6:05 PM : > To: Uwe Schindler : > Cc: Lucene Dev : > Subject: Re: Policeman Jenkins lost it's "/view/Lucene-Solr/" : > : > : > Uwe? ... you around? can you please re-add this jenkins view? : > : > : Date: Thu, 2 Jul 2020 17:36:25 -0700 (MST) : > : From: Chris Hostetter : > : To: Uwe Schindler : > : Cc: Lucene Dev : > : Subject: Policeman Jenkins lost it's "/view/Lucene-Solr/" : > : : > : : > : Uwe: the "/view/Lucene-Solr/" View that my reports were using to restrict the : > : jobs it checked on your jenkins server (to only lucene/solr jobs) seems to : > : have been removed... : > : : > : https://jenkins.thetaphi.de/view/Lucene-Solr/ : > : : > : ...as a result, my reports evidently haven't detected any failures (or : > : successes) from your jenkins jobs in a while... : > : : > : http://fucit.org/solr-jenkins-reports/ : > : : > : ...can you please add that view back? : > : : > : : > : -Hoss : > : http://www.lucidworks.com/ : > : : > : > -Hoss : > http://www.lucidworks.com/ : : -Hoss http://www.lucidworks.com/ - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
RE: Policeman Jenkins lost it's "/view/Lucene-Solr/"
Hi, it seem to got lost on last Update. I was on vacation last week, so missed your mail. I added it back, Uwe - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Chris Hostetter > Sent: Monday, July 13, 2020 6:05 PM > To: Uwe Schindler > Cc: Lucene Dev > Subject: Re: Policeman Jenkins lost it's "/view/Lucene-Solr/" > > > Uwe? ... you around? can you please re-add this jenkins view? > > : Date: Thu, 2 Jul 2020 17:36:25 -0700 (MST) > : From: Chris Hostetter > : To: Uwe Schindler > : Cc: Lucene Dev > : Subject: Policeman Jenkins lost it's "/view/Lucene-Solr/" > : > : > : Uwe: the "/view/Lucene-Solr/" View that my reports were using to restrict > the > : jobs it checked on your jenkins server (to only lucene/solr jobs) seems to > : have been removed... > : > : https://jenkins.thetaphi.de/view/Lucene-Solr/ > : > : ...as a result, my reports evidently haven't detected any failures (or > : successes) from your jenkins jobs in a while... > : > : http://fucit.org/solr-jenkins-reports/ > : > : ...can you please add that view back? > : > : > : -Hoss > : http://www.lucidworks.com/ > : > > -Hoss > http://www.lucidworks.com/ - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: Policeman Jenkins lost it's "/view/Lucene-Solr/"
Uwe? ... you around? can you please re-add this jenkins view? : Date: Thu, 2 Jul 2020 17:36:25 -0700 (MST) : From: Chris Hostetter : To: Uwe Schindler : Cc: Lucene Dev : Subject: Policeman Jenkins lost it's "/view/Lucene-Solr/" : : : Uwe: the "/view/Lucene-Solr/" View that my reports were using to restrict the : jobs it checked on your jenkins server (to only lucene/solr jobs) seems to : have been removed... : : https://jenkins.thetaphi.de/view/Lucene-Solr/ : : ...as a result, my reports evidently haven't detected any failures (or : successes) from your jenkins jobs in a while... : : http://fucit.org/solr-jenkins-reports/ : : ...can you please add that view back? : : : -Hoss : http://www.lucidworks.com/ : -Hoss http://www.lucidworks.com/ - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Policeman Jenkins lost it's "/view/Lucene-Solr/"
Uwe: the "/view/Lucene-Solr/" View that my reports were using to restrict the jobs it checked on your jenkins server (to only lucene/solr jobs) seems to have been removed... https://jenkins.thetaphi.de/view/Lucene-Solr/ ...as a result, my reports evidently haven't detected any failures (or successes) from your jenkins jobs in a while... http://fucit.org/solr-jenkins-reports/ ...can you please add that view back? -Hoss http://www.lucidworks.com/ - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
