Re: StreamExpressionTest failures
I reverted the change in behavior (not the entire commit which was 99% good
stuff) which will also fix the test. Just pushed to master and will do for
8x in a few minutes.
~ David
On Sat, Jun 27, 2020 at 2:33 AM David Smiley
wrote:
> This fails due to my refactor of path handling inside the cat stream
> (oops!). Either Solr is wrong or the test is wrong depending on your point
> of view as to what sort of paths Solr should expose. See the dev list
> thread I started on the choice.
>
> On Fri, Jun 26, 2020 at 8:12 AM Erick Erickson
> wrote:
>
>> Wonder if Uwe has any insights?
>>
>> > On Jun 25, 2020, at 9:32 PM, Joel Bernstein wrote:
>> >
>> > This just started failing out of the blue today. I wonder what changed?
>> Is it straightforward to detect windows in the test cases?
>> >
>> >
>> > Joel Bernstein
>> > http://joelsolr.blogspot.com/
>> >
>> >
>> > On Thu, Jun 25, 2020 at 7:46 PM Erick Erickson
>> wrote:
>> > This test fails on line 3500, here’s the code block. Notice that the
>> test carefully constructs
>> > the test string with the system file separator. Even so, the the tuple
>> has a *nix style separator
>> > and the test string a Windows separator.
>> >
>> >
>> > final String expectedSecondLevel1Path = "directory1" + File.separator +
>> "secondLevel1.txt";
>> > for (int i = 0; i < 4; i++) {
>> > Tuple t = tuples.get(i);
>> > assertEquals("secondLevel1.txt line " + String.valueOf(i+1),
>> t.get("line"));
>> > assertEquals(expectedSecondLevel1Path, t.get("file"));
>> > }
>> >
>> > FAILED:
>> org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testCatStreamDirectoryCrawl
>> >
>> > Error Message:
>> > expected: but
>> was:
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> > For additional commands, e-mail: dev-h...@lucene.apache.org
>> >
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>
>>
Re: StreamExpressionTest failures
This fails due to my refactor of path handling inside the cat stream
(oops!). Either Solr is wrong or the test is wrong depending on your point
of view as to what sort of paths Solr should expose. See the dev list
thread I started on the choice.
On Fri, Jun 26, 2020 at 8:12 AM Erick Erickson
wrote:
> Wonder if Uwe has any insights?
>
> > On Jun 25, 2020, at 9:32 PM, Joel Bernstein wrote:
> >
> > This just started failing out of the blue today. I wonder what changed?
> Is it straightforward to detect windows in the test cases?
> >
> >
> > Joel Bernstein
> > http://joelsolr.blogspot.com/
> >
> >
> > On Thu, Jun 25, 2020 at 7:46 PM Erick Erickson
> wrote:
> > This test fails on line 3500, here’s the code block. Notice that the
> test carefully constructs
> > the test string with the system file separator. Even so, the the tuple
> has a *nix style separator
> > and the test string a Windows separator.
> >
> >
> > final String expectedSecondLevel1Path = "directory1" + File.separator +
> "secondLevel1.txt";
> > for (int i = 0; i < 4; i++) {
> > Tuple t = tuples.get(i);
> > assertEquals("secondLevel1.txt line " + String.valueOf(i+1),
> t.get("line"));
> > assertEquals(expectedSecondLevel1Path, t.get("file"));
> > }
> >
> > FAILED:
> org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testCatStreamDirectoryCrawl
> >
> > Error Message:
> > expected: but
> was:
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> > For additional commands, e-mail: dev-h...@lucene.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>
Re: StreamExpressionTest failures
Wonder if Uwe has any insights?
> On Jun 25, 2020, at 9:32 PM, Joel Bernstein wrote:
>
> This just started failing out of the blue today. I wonder what changed? Is it
> straightforward to detect windows in the test cases?
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/
>
>
> On Thu, Jun 25, 2020 at 7:46 PM Erick Erickson
> wrote:
> This test fails on line 3500, here’s the code block. Notice that the test
> carefully constructs
> the test string with the system file separator. Even so, the the tuple has a
> *nix style separator
> and the test string a Windows separator.
>
>
> final String expectedSecondLevel1Path = "directory1" + File.separator +
> "secondLevel1.txt";
> for (int i = 0; i < 4; i++) {
> Tuple t = tuples.get(i);
> assertEquals("secondLevel1.txt line " + String.valueOf(i+1), t.get("line"));
> assertEquals(expectedSecondLevel1Path, t.get("file"));
> }
>
> FAILED:
> org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testCatStreamDirectoryCrawl
>
> Error Message:
> expected: but
> was:
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: StreamExpressionTest failures
This just started failing out of the blue today. I wonder what changed? Is
it straightforward to detect windows in the test cases?
Joel Bernstein
http://joelsolr.blogspot.com/
On Thu, Jun 25, 2020 at 7:46 PM Erick Erickson
wrote:
> This test fails on line 3500, here’s the code block. Notice that the test
> carefully constructs
> the test string with the system file separator. Even so, the the tuple has
> a *nix style separator
> and the test string a Windows separator.
>
>
> final String expectedSecondLevel1Path = "directory1" + File.separator +
> "secondLevel1.txt";
> for (int i = 0; i < 4; i++) {
> Tuple t = tuples.get(i);
> assertEquals("secondLevel1.txt line " + String.valueOf(i+1),
> t.get("line"));
> assertEquals(expectedSecondLevel1Path, t.get("file"));
> }
>
> FAILED:
> org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testCatStreamDirectoryCrawl
>
> Error Message:
> expected: but
> was:
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>
StreamExpressionTest failures
This test fails on line 3500, here’s the code block. Notice that the test
carefully constructs
the test string with the system file separator. Even so, the the tuple has a
*nix style separator
and the test string a Windows separator.
final String expectedSecondLevel1Path = "directory1" + File.separator +
"secondLevel1.txt";
for (int i = 0; i < 4; i++) {
Tuple t = tuples.get(i);
assertEquals("secondLevel1.txt line " + String.valueOf(i+1), t.get("line"));
assertEquals(expectedSecondLevel1Path, t.get("file"));
}
FAILED:
org.apache.solr.client.solrj.io.stream.StreamExpressionTest.testCatStreamDirectoryCrawl
Error Message:
expected: but was:
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Resolved] (SOLR-9549) StreamExpressionTest failures
[ https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein resolved SOLR-9549. -- Resolution: Resolved > StreamExpressionTest failures > - > > Key: SOLR-9549 > URL: https://issues.apache.org/jira/browse/SOLR-9549 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward > > Reproduces for me on master: > ant test -Dtestcase=StreamExpressionTest > -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os > -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9549) StreamExpressionTest failures
[ https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513347#comment-15513347 ] Michael McCandless commented on SOLR-9549: -- Woops, that is indeed right! Thanks for fixing [~joel.bernstein]. > StreamExpressionTest failures > - > > Key: SOLR-9549 > URL: https://issues.apache.org/jira/browse/SOLR-9549 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward > > Reproduces for me on master: > ant test -Dtestcase=StreamExpressionTest > -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os > -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9549) StreamExpressionTest failures
[ https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513113#comment-15513113 ] ASF subversion and git services commented on SOLR-9549: --- Commit 75e69c5198c02e6635eed274b03ea759ef1c4818 in lucene-solr's branch refs/heads/master from Joel [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=75e69c5 ] SOLR-9549: Fix bug in advancing docValues > StreamExpressionTest failures > - > > Key: SOLR-9549 > URL: https://issues.apache.org/jira/browse/SOLR-9549 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward > > Reproduces for me on master: > ant test -Dtestcase=StreamExpressionTest > -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os > -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9549) StreamExpressionTest failures
[ https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513083#comment-15513083 ] Joel Bernstein commented on SOLR-9549: -- Yep that did the trick. Committing a fix shortly. > StreamExpressionTest failures > - > > Key: SOLR-9549 > URL: https://issues.apache.org/jira/browse/SOLR-9549 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward > > Reproduces for me on master: > ant test -Dtestcase=StreamExpressionTest > -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os > -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9549) StreamExpressionTest failures
[ https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513076#comment-15513076 ] Joel Bernstein commented on SOLR-9549: -- I think we just need to advance to *doc* rather then *valuesDocID*. > StreamExpressionTest failures > - > > Key: SOLR-9549 > URL: https://issues.apache.org/jira/browse/SOLR-9549 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward > > Reproduces for me on master: > ant test -Dtestcase=StreamExpressionTest > -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os > -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9549) StreamExpressionTest failures
[
https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513070#comment-15513070
]
Joel Bernstein commented on SOLR-9549:
--
I suspect the problem is in this block of code:
{code}
public void collect(int doc) throws IOException{
int valuesDocID = leafOutcomeValue.docID();
if (valuesDocID < doc) {
valuesDocID = leafOutcomeValue.advance(valuesDocID);
}
int outcome;
if (valuesDocID == doc) {
outcome = (int) leafOutcomeValue.longValue();
} else {
outcome = 0;
}
outcome = trainingParams.positiveLabel == outcome? 1 : 0;
if (outcome == 1) {
positiveDocsSet.set(context.docBase + doc);
}
docsSet.set(context.docBase+doc);
}
{code
> StreamExpressionTest failures
> -
>
> Key: SOLR-9549
> URL: https://issues.apache.org/jira/browse/SOLR-9549
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Alan Woodward
>
> Reproduces for me on master:
> ant test -Dtestcase=StreamExpressionTest
> -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os
> -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-9549) StreamExpressionTest failures
[
https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513070#comment-15513070
]
Joel Bernstein edited comment on SOLR-9549 at 9/22/16 11:51 AM:
I suspect the problem is in this block of code:
{code}
public void collect(int doc) throws IOException{
int valuesDocID = leafOutcomeValue.docID();
if (valuesDocID < doc) {
valuesDocID = leafOutcomeValue.advance(valuesDocID);
}
int outcome;
if (valuesDocID == doc) {
outcome = (int) leafOutcomeValue.longValue();
} else {
outcome = 0;
}
outcome = trainingParams.positiveLabel == outcome? 1 : 0;
if (outcome == 1) {
positiveDocsSet.set(context.docBase + doc);
}
docsSet.set(context.docBase+doc);
}
{code}
was (Author: joel.bernstein):
I suspect the problem is in this block of code:
{code}
public void collect(int doc) throws IOException{
int valuesDocID = leafOutcomeValue.docID();
if (valuesDocID < doc) {
valuesDocID = leafOutcomeValue.advance(valuesDocID);
}
int outcome;
if (valuesDocID == doc) {
outcome = (int) leafOutcomeValue.longValue();
} else {
outcome = 0;
}
outcome = trainingParams.positiveLabel == outcome? 1 : 0;
if (outcome == 1) {
positiveDocsSet.set(context.docBase + doc);
}
docsSet.set(context.docBase+doc);
}
{code
> StreamExpressionTest failures
> -
>
> Key: SOLR-9549
> URL: https://issues.apache.org/jira/browse/SOLR-9549
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Alan Woodward
>
> Reproduces for me on master:
> ant test -Dtestcase=StreamExpressionTest
> -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os
> -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9549) StreamExpressionTest failures
[ https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513048#comment-15513048 ] Joel Bernstein commented on SOLR-9549: -- [~mikemccand], can you provide some guidance on the changes to TextLogisticRegressionQParserPlugin? > StreamExpressionTest failures > - > > Key: SOLR-9549 > URL: https://issues.apache.org/jira/browse/SOLR-9549 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward > > Reproduces for me on master: > ant test -Dtestcase=StreamExpressionTest > -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os > -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9549) StreamExpressionTest failures
[ https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513042#comment-15513042 ] Joel Bernstein commented on SOLR-9549: -- I think this is due to a change to the TextLogisticRegressionQParserPlugin from LUCENE-7407. > StreamExpressionTest failures > - > > Key: SOLR-9549 > URL: https://issues.apache.org/jira/browse/SOLR-9549 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward > > Reproduces for me on master: > ant test -Dtestcase=StreamExpressionTest > -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os > -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9549) StreamExpressionTest failures
[ https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512999#comment-15512999 ] Joel Bernstein commented on SOLR-9549: -- It looks the failures kicked in yesterday. I'll take a look. > StreamExpressionTest failures > - > > Key: SOLR-9549 > URL: https://issues.apache.org/jira/browse/SOLR-9549 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward > > Reproduces for me on master: > ant test -Dtestcase=StreamExpressionTest > -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os > -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9549) StreamExpressionTest failures
[ https://issues.apache.org/jira/browse/SOLR-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512659#comment-15512659 ] Alan Woodward commented on SOLR-9549: - cc [~joel.bernstein] > StreamExpressionTest failures > - > > Key: SOLR-9549 > URL: https://issues.apache.org/jira/browse/SOLR-9549 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward > > Reproduces for me on master: > ant test -Dtestcase=StreamExpressionTest > -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os > -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-9549) StreamExpressionTest failures
Alan Woodward created SOLR-9549: --- Summary: StreamExpressionTest failures Key: SOLR-9549 URL: https://issues.apache.org/jira/browse/SOLR-9549 Project: Solr Issue Type: Bug Security Level: Public (Default Security Level. Issues are Public) Reporter: Alan Woodward Reproduces for me on master: ant test -Dtestcase=StreamExpressionTest -Dtests.method=testBasicTextLogitStream -Dtests.seed=DB749AA9C9E30657 -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=os -Dtests.timezone=Asia/Bahrain -Dtests.asserts=true -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
