Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-15 Thread Yonik Seeley
On Fri, Jul 15, 2011 at 11:08 AM, Erick Erickson wrote: > This is even a question? It costs nothing to mention the person who > brought up the bug (well, OK, the time to type the name) It was merely a question of consistency, and I think that question has now been answered. -Yonik http://www.luc

Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-15 Thread Erick Erickson
--- >>> Uwe Schindler >>> H.-H.-Meier-Allee 63, D-28213 Bremen >>> http://www.thetaphi.de >>> eMail: u...@thetaphi.de >>> >>> >>>> -Original Message- >>>> From: Mark Miller [mailto:markrmil...@gmail.com] >>>

Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-14 Thread Grant Ingersoll
://www.thetaphi.de >> eMail: u...@thetaphi.de >> >> >>> -Original Message- >>> From: Mark Miller [mailto:markrmil...@gmail.com] >>> Sent: Wednesday, July 13, 2011 10:20 PM >>> To: dev@lucene.apache.org >>> Subject: Re: svn commit: r

Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-13 Thread Simon Willnauer
> From: Mark Miller [mailto:markrmil...@gmail.com] >> Sent: Wednesday, July 13, 2011 10:20 PM >> To: dev@lucene.apache.org >> Subject: Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt >> >> I try to credit the person that raised the bug as well. >> &

Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-13 Thread Chris Hostetter
: But I don't think this has been historically done (i.e. I bet >95% of : bug reports in CHANGES do not list the author if they did not : contribute to the patch). i can't find it now, but i seem to recall a recent discussion specificly on the fact that we should do more to acknowledge people wh

RE: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-13 Thread Uwe Schindler
> To: dev@lucene.apache.org > Subject: Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt > > I try to credit the person that raised the bug as well. > > If someone else raises the bug and I fix it, doing pretty much all of the work, > then I do "jon doe, mark miller" >

Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-13 Thread Mark Miller
I try to credit the person that raised the bug as well. If someone else raises the bug and I fix it, doing pretty much all of the work, then I do "jon doe, mark miller" If someone else raises the bug and does most of the work, and I just have to tweak or clean it up a bit at most, I do "jon doe

Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-13 Thread Yonik Seeley
On Wed, Jul 13, 2011 at 4:12 PM, Michael McCandless wrote: > I try to credit whoever raised the bug even if they don't make a > patch, test case, etc. > > The effort to find, characterize, report a bug back to us is sizable > and people should be given credit for that, I think. But I don't think

Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-13 Thread Michael McCandless
I try to credit whoever raised the bug even if they don't make a patch, test case, etc. The effort to find, characterize, report a bug back to us is sizable and people should be given credit for that, I think. Mike McCandless http://blog.mikemccandless.com On Wed, Jul 13, 2011 at 4:06 PM, Yonik

Re: svn commit: r1146329 - /lucene/dev/trunk/solr/CHANGES.txt

2011-07-13 Thread Yonik Seeley
I think our normal practice has been to include people who have actually contributed patches/code or substantial design. Not sure if we want to change that practice or not - just relaying what has been the norm. -Yonik http://www.lucidimagination.com On Wed, Jul 13, 2011 at 3:58 PM, wrote: >