Re: Remaining Work/Priorities

2016-10-04 Thread Itamar Syn-Hershko
Elad, casting is only a compiler hack. Keeping the code as close to it's original Java form is important for many reasons, and as such I think we should avoid making such changes. -- Itamar Syn-Hershko http://code972.com | @synhershko Freelance Developer &

Re: Remaining Work/Priorities

2016-10-04 Thread Itamar Syn-Hershko
Awesome, thanks for all the hard work Shad! Our first priority should be fixing all remaining tests - in particular the one in Core. We should be ready to release and stamp our builds as 100% stable. As you mentioned, this could be an infrastructure issue - hopefully *Connie *can give a status

[GitHub] lucenenet pull request #188: Fixed 64 Failing Facet Tests and Finished Facet...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #187: Fixed 76 QueryParser Failing Tests

2016-10-04 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/187#discussion_r81840724 --- Diff: src/Lucene.Net.QueryParser/Surround/Parser/QueryParser.cs --- @@ -883,7 +883,7 @@ private void Jj_rescan_token()

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-04 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/190#discussion_r81838986 --- Diff: Lucene.Net.sln --- @@ -59,14 +60,14 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Lucene.Net.Suggest", "src\L EndProject

[GitHub] lucenenet issue #174: Ported over Lucene.Net.Spatial

2016-10-04 Thread synhershko
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/174 The spatial lib needs to be brought up to date with the Java 4.8.0 branch (which I believe this is what this PR does, but this needs verification). The latest spatial bits will not work before

[GitHub] lucenenet pull request #190: Ported Analysis.Stempel

2016-10-04 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/190#discussion_r81839278 --- Diff: src/Lucene.Net.Core/Support/DataInputStream.cs --- @@ -0,0 +1,323 @@ +using System; +using System.IO; + +namespace

[GitHub] lucenenet issue #174: Ported over Lucene.Net.Spatial

2016-10-04 Thread eladmarg
Github user eladmarg commented on the issue: https://github.com/apache/lucenenet/pull/174 Hi, what should be done here? I can try to re-port the spatial4j will this solve the issue? --- If your project is set up for it, you can reply to this email and have your reply appear on