[GitHub] lucenenet issue #176: Ported QueryParser

Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/176 Hi, sorry it took me so long to review. I wanted to review properly and give proper feedback to complement your hard (and very professional!) work here. So, 1. This makes

[GitHub] lucenenet issue #176: Ported QueryParser

Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/176 Ok, I have moved the test to Lucene.Net.Tests/core/Support. Apparently there *was* a directory with this name, but it had been removed from the project. Not sure what the reasoning was for

[GitHub] lucenenet issue #176: Ported QueryParser

Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/176 > This is usually where we put all .NET specific stuff that is required by Core / subprojects: > https://github.com/apache/lucenenet/tree/master/src/Lucene.Net.Core/Support/Compatibility

[GitHub] lucenenet issue #176: Ported QueryParser

Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/176 This is usually where we put all .NET specific stuff that is required by Core / subprojects: https://github.com/apache/lucenenet/tree/master/src/Lucene.Net.Core/Support/Compatibility

[GitHub] lucenenet issue #176: Ported QueryParser

Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/176 Another correction - the Lucene.Net 3.0.3 code had a bug. When passing `0`, it would format the boost as `^.0`, but if you passed `0.123` you would get `^0.123`. I checked through

Re: [GitHub] lucenenet issue #176: Ported QueryParser

There wasn't one for the 4.8 version, this is what's being ported now -- Itamar Syn-Hershko http://code972.com | @synhershko Freelance Developer & Consultant Lucene.NET committer and PMC member On Fri, Aug 5, 2016 at 4:20 PM, Benjamin Collins

[GitHub] lucenenet issue #176: Ported QueryParser

Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/176 Left one minor comments, looks good to merge otherwise. Thanks for your help! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: [GitHub] lucenenet issue #176: Ported QueryParser

There used to be a QueryParser and then it was removed - what happened there? On Tue, Aug 2, 2016 at 4:37 PM, synhershko wrote: > Github user synhershko commented on the issue: > > https://github.com/apache/lucenenet/pull/176 > > Looks good! will review shortly,