[GitHub] lucenenet issue #177: Limiting uses of static variables and methods in Testc...

2016-08-12 Thread synhershko
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/177 Awesome work, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] lucenenet issue #177: Limiting uses of static variables and methods in Testc...

2016-08-08 Thread conniey
Github user conniey commented on the issue: https://github.com/apache/lucenenet/pull/177 @synhershko Thank you for looking over the PR! >(1) might have found a bug I went through those classes again and fixed all the instances that I found where `query` and `searcher`

[GitHub] lucenenet issue #177: Limiting uses of static variables and methods in Testc...

2016-08-06 Thread synhershko
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/177 Looks great! Added a few comments (1) might have found a bug - you didn't change local vars in some occasions so I had commented in some of them, (2) please document all test API

[GitHub] lucenenet issue #177: Limiting uses of static variables and methods in Testc...

2016-08-04 Thread synhershko
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/177 👍 lots of files to review :) will be on it asap. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your