[GitHub] lucenenet pull request: Debug.Assert with side effects fix

2015-05-09 Thread synhershko
Github user synhershko commented on the pull request: https://github.com/apache/lucenenet/pull/142#issuecomment-100528838 All looks good, I don't see anything to discuss here really. Will merge now. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] lucenenet pull request: Debug.Assert with side effects fix

2015-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request: Debug.Assert with side effects fix

2015-05-08 Thread laimis
Github user laimis commented on the pull request: https://github.com/apache/lucenenet/pull/142#issuecomment-100421169 What I have here should be all that show up in unit test failures. Will do another pass in couple days to see if there are more spots like these in the code base.