[GitHub] lucenenet pull request: make sure to invoke appropriate CompareVal...

2015-04-26 Thread laimis
GitHub user laimis opened a pull request: https://github.com/apache/lucenenet/pull/132 make sure to invoke appropriate CompareValues via FieldComparator .NET port introduced FieldComparator that generic FieldComparatorT inherits from. The issue is that the CompareValues it

[GitHub] lucenenet pull request: make sure to invoke appropriate CompareVal...

2015-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request: make sure to invoke appropriate CompareVal...

2015-04-26 Thread synhershko
Github user synhershko commented on the pull request: https://github.com/apache/lucenenet/pull/132#issuecomment-96372011 Good catch, will merge now Can you evaluate if we still need that non-generic class? --- If your project is set up for it, you can reply to this email and

[GitHub] lucenenet pull request: make sure to invoke appropriate CompareVal...

2015-04-26 Thread laimis
Github user laimis commented on the pull request: https://github.com/apache/lucenenet/pull/132#issuecomment-96412864 @synhershko took a look, it seems like we need it because there are places using this without explicit specification of generic type T to match what Lucene is doing