Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213849508
Thanks, merged. On your next PR, please work on a branch, it is an ill
practice in git to merge from someone else's master.
---
If your project is set up for it,
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user devheroo closed the pull request at:
https://github.com/apache/lucenenet/pull/167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user devheroo reopened a pull request:
https://github.com/apache/lucenenet/pull/167
replace InstanceNotFoundException to allow building on Mono
It will be great to keep LuceneNet cross platform and compatible with Mono.
This is just a simple fix to make the build pass on
Github user devheroo commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213473241
Thanks for the tip , I made the change regarding the
InvalidOperationException and also I had to rename a file path inside
Lucene.Net.Codecs.Tests.csproj because
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213343394
Thanks! I've made a comment on the Exception type used
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/167#discussion_r60710792
--- Diff: src/Lucene.Net.Facet/Taxonomy/WriterCache/CollisionMap.cs ---
@@ -261,7 +261,7 @@ public Entry Next()
Entry e =
GitHub user devheroo opened a pull request:
https://github.com/apache/lucenenet/pull/167
replace InstanceNotFoundException to allow building on Mono
It will be great to keep LuceneNet cross platform and compatible with Mono.
This is just a simple fix to make the build pass on