GitHub user laimis opened a pull request:
https://github.com/apache/lucenenet/pull/145
use Environment.TickCount instead DateTime.Now.Millisecond
During the port System.currentTimeMillis was translated to
System.DateTime.Now.Millisecond which are not equivalent. This introduced
Github user laimis commented on the pull request:
https://github.com/apache/lucenenet/pull/145#issuecomment-102659773
Also removed LongRunningTest or Ignore attributes on the tests that used to
fail because of this before.
---
If your project is set up for it, you can reply to this
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/145#issuecomment-102659785
Can you rebase please? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user laimis commented on the pull request:
https://github.com/apache/lucenenet/pull/145#issuecomment-102660198
@synhershko can you check now? If it is too messy I can reopen a different
PR, ot sure if I did this right
---
If your project is set up for it, you can reply to
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/145#discussion_r30463210
--- Diff: src/Lucene.Net.Core/Util/OfflineSorter.cs ---
@@ -34,486 +34,6 @@ namespace Lucene.Net.Util
/// /summary
public sealed class
Github user laimis commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/145#discussion_r30463250
--- Diff: src/Lucene.Net.Core/Util/OfflineSorter.cs ---
@@ -34,486 +34,6 @@ namespace Lucene.Net.Util
/// /summary
public sealed class
Github user laimis commented on the pull request:
https://github.com/apache/lucenenet/pull/145#issuecomment-102663771
@synhershko oh yeah, you are right, I will keep that in mind.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/145#issuecomment-102662514
Good catch, I'll merge now.
For the record, `DateTime.UtcNow.Ticks` is a closer equivalent to
`System.currentTimeMillis` but for the purpose of this
