[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-18 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71187179 --- Diff: src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs --- @@ -85,24 +85,24 @@ public static IndexWriter MockIndexWriter(Directory dir,

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-18 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71186208 --- Diff: src/Lucene.Net.Tests/core/Index/TestBinaryDocValuesUpdates.cs --- @@ -1109,25 +1109,55 @@ public virtual void

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-18 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71185454 --- Diff: src/Lucene.Net.Tests.Queries/TestCustomScoreQuery.cs --- @@ -334,11 +334,11 @@ private void VerifyResults(float boost, IndexSearcher s,

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-18 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71185299 --- Diff: src/Lucene.Net.Tests.Join/Lucene.Net.Tests.Join.csproj --- @@ -31,7 +31,7 @@ -

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-18 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71184894 --- Diff: src/Lucene.Net.TestFramework/Search/QueryUtils.cs --- @@ -442,15 +445,17 @@ private class CollectorAnonymousInnerClassHelper2 : Collector

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-16 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71072173 --- Diff: src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs --- @@ -85,24 +85,24 @@ public static IndexWriter MockIndexWriter(Directory dir,

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-16 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71072078 --- Diff: src/Lucene.Net.Tests/core/Index/TestBinaryDocValuesUpdates.cs --- @@ -1109,25 +1109,55 @@ public virtual void

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-16 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71072042 --- Diff: src/Lucene.Net.Tests.Queries/TestCustomScoreQuery.cs --- @@ -334,11 +334,11 @@ private void VerifyResults(float boost, IndexSearcher s,

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-16 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71072025 --- Diff: src/Lucene.Net.Tests.Join/Lucene.Net.Tests.Join.csproj --- @@ -31,7 +31,7 @@ -

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-16 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/172#discussion_r71071991 --- Diff: src/Lucene.Net.TestFramework/Search/QueryUtils.cs --- @@ -442,15 +445,17 @@ private class CollectorAnonymousInnerClassHelper2 : Collector

[GitHub] lucenenet pull request #172: Removing/limiting uses of static variables and ...

2016-07-15 Thread conniey
GitHub user conniey opened a pull request: https://github.com/apache/lucenenet/pull/172 Removing/limiting uses of static variables and methods in Testcases This PR would allow an easier transition to using xUnit. xUnit by default, runs its tests in parallel and asynchronously.