[GitHub] lucenenet pull request #198: Removing C# 6 features

2016-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #197: Fixing build errors

2016-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet issue #197: Fixing build errors

2016-12-06 Thread conniey
Github user conniey commented on the issue: https://github.com/apache/lucenenet/pull/197 @NightOwl888 Awesome! Thanks for the explanation. I updated my commit message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] lucenenet issue #198: Updating minimum Visual Studio version to 2015

2016-12-06 Thread conniey
Github user conniey commented on the issue: https://github.com/apache/lucenenet/pull/198 @NightOwl888 I replaced all the C# 6 features instead, so it'll continue to work in older VS versions. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] lucenenet issue #197: Fixing build errors

2016-12-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/197 See https://github.com/apache/lucenenet/commit/e8735ed9622ab56eaf86bae6394f93f3fb058d30 for an example. If it is something that needs to go in right away (such as this) you could

[GitHub] lucenenet issue #197: Fixing build errors

2016-12-06 Thread conniey
Github user conniey commented on the issue: https://github.com/apache/lucenenet/pull/197 @NightOwl888 Ahh okay! Thanks for letting me know. Just to make sure I understand it correctly, when I am creating a commit, I'll preemptively add "fixes " to my commit message. And the where

[GitHub] lucenenet issue #198: Updating minimum Visual Studio version to 2015

2016-12-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/198 Thanks for informing - this was something that slipped in by accident. Ever since I first noticed that VS2012 can't compile these features, I have been trying to keep them out of the code

[GitHub] lucenenet pull request #198: Updating minimum Visual Studio version to 2015

2016-12-06 Thread conniey
GitHub user conniey opened a pull request: https://github.com/apache/lucenenet/pull/198 Updating minimum Visual Studio version to 2015 There are C# 6 features in use (ie.

[GitHub] lucenenet issue #197: Fixing build errors

2016-12-06 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/197 Not sure why this happened - probably a botched merge of some kind. I'll pull this into master. For future reference, it would work smoother on my end if you just add `fixes #197` or