[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-10-03 Thread csharptest
Github user csharptest commented on the issue: https://github.com/apache/lucenenet/pull/188 No problem, glad you like it. Should serve you well as its been in production for years now without issue. Do let me know if you need advice on usage. -- Roger >

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-10-02 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/188 @synhershko > I say let's first release, then see who uses this. Once we see a lot of usage, we may reconsider the implementation. WDYT? In that case this is ready to go.

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-10-02 Thread synhershko
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/188 > A plain old generic Dictionary works fine, but may use more RAM than the designers intended. I am totally okay with that. We should aim to get something out the door asap, and then

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-10-02 Thread csharptest
Github user csharptest commented on the issue: https://github.com/apache/lucenenet/pull/188 I have no problem with this. Feel free to extract it. You can probably leave the interfaces behind if you don't need them. -- Roger ro...@csharptest.com >

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-10-02 Thread eladmarg
Github user eladmarg commented on the issue: https://github.com/apache/lucenenet/pull/188 there are few files of the LurchTable, so all we need is @csharptest permission, and then we can just copy them to the solution and fork the relevant parts. I think if we'll contact

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-09-29 Thread eladmarg
Github user eladmarg commented on the issue: https://github.com/apache/lucenenet/pull/188 Hi, just found a great implementation which does exactly what is expected (truly same as java) please take a look at :

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-09-29 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/188 > which of the sub-project not ported yet? AFAIK, these are the pieces that are missing that are not currently being worked on, but you should send an email to

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-09-29 Thread eladmarg
Github user eladmarg commented on the issue: https://github.com/apache/lucenenet/pull/188 by the way, another option is to port the java equivalent [LinkedHashMap](http://developer.classpath.org/doc/java/util/LinkedHashMap-source.html) derived from HashSet and just implement the

[GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...

2016-09-26 Thread eladmarg
Github user eladmarg commented on the issue: https://github.com/apache/lucenenet/pull/188 Fantastic! this is awesome, thank you so much! @synhershko please merge Again, thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear