[GitHub] madlib issue #287: Fix incorrect dict expansion in table header

2018-07-10 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/287 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/542/ ---

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201489373 --- Diff: src/modules/recursive_partitioning/DT_impl.hpp --- @@ -1512,6 +1512,9 @@ DecisionTree::computeVariableImportance(

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201501719 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -1291,38 +1300,64 @@ def _create_group_table(

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201462356 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -616,23 +628,20 @@ def forest_train(

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201490136 --- Diff: src/modules/recursive_partitioning/decision_tree.cpp --- @@ -502,10 +502,13 @@ get_variable_importance::run(AnyType ){ ColumnVector

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201493117 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -1333,42 +1368,69 @@ def _create_group_table( #

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-10 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201492311 --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.py_in --- @@ -1291,38 +1300,64 @@ def _create_group_table(

[GitHub] madlib issue #287: Fix incorrect dict expansion in table header

2018-07-10 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/287 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/541/ ---

[GitHub] madlib issue #288: Jira:1239: Converts features from multiple columns into a...

2018-07-10 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/288 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/539/ ---