Github user kaknikhil commented on the issue:
https://github.com/apache/madlib/pull/318
@orhankislal The new changes look good. Apart from the 2 minor comments
LGTM +1
---
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/318#discussion_r217842739
--- Diff: src/madpack/create_changelist.py ---
@@ -0,0 +1,239 @@
+#!/usr/bin/python
+#
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/318#discussion_r217842978
--- Diff: src/madpack/create_changelist.py ---
@@ -0,0 +1,239 @@
+#!/usr/bin/python
+#
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/318
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/681/
---
Github user orhankislal commented on the issue:
https://github.com/apache/madlib/pull/318
@kaknikhil I checked the 1.11 -> 1.12 scenario. The tool is missing
the`tree_train` and `forest_train` entries. The change seems to be the removal
of `surrogate_params` and the addition of `null_
