[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...

2018-12-27 Thread hpandeycodeit
Github user hpandeycodeit commented on the issue: https://github.com/apache/madlib/pull/343 @jingyimei I have fixed the linear regression one. Thanks! ---

[GitHub] madlib pull request #343: Linear Regression: Support for JSON and special ch...

2018-12-27 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/343 Linear Regression: Support for JSON and special characters JIRA: MADLIB-1284 - Modified code in linear.py_in to support special characters and JSON data type - Written

[GitHub] madlib issue #315: JIRA:1060 - Modified KNN to accept expressions in point_c...

2018-09-07 Thread hpandeycodeit
Github user hpandeycodeit commented on the issue: https://github.com/apache/madlib/pull/315 Thanks for the update @fmcquillan99! I have fixed the error above and added a test case as well. ---

[GitHub] madlib issue #315: JIRA:1060 - Modified KNN to accept expressions in point_c...

2018-09-07 Thread hpandeycodeit
Github user hpandeycodeit commented on the issue: https://github.com/apache/madlib/pull/315 @fmcquillan99 @njayaram2 Issue is here `{point_id} , {point_column_name} as {p_col_name} {label_column_name} from {point_source}` I will handle it and add a test

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215149356 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215149235 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -264,12 +260,17 @@ def knn(schema_madlib, point_source, point_column_name, point_id

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215148966 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-09-05 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r215148640 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source, point_column_name

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214415305 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -122,5 +122,13 @@ select knn('knn_train_data_reg','data','id','label','knn_test_data

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214415227 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -290,11 +303,11 @@ def knn(schema_madlib, point_source, point_column_name, point_id

[GitHub] madlib pull request #315: JIRA:1060 - Modified KNN to accept expressions in ...

2018-08-31 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/315#discussion_r214414914 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -264,12 +275,14 @@ def knn(schema_madlib, point_source, point_column_name, point_id

[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

2018-07-09 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/288#discussion_r200891497 --- Diff: src/ports/postgres/modules/cols_vec/cols2vec.py_in --- @@ -0,0 +1,104 @@ +""" +@file cols2vec.py_in +

[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

2018-07-06 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/288#discussion_r200787816 --- Diff: src/ports/postgres/modules/cols_vec/cols2vec.py_in --- @@ -0,0 +1,110 @@ +""" +@file cols2vec.py_in +

[GitHub] madlib pull request #288: Jira:1239: Converts features from multiple columns...

2018-07-06 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/288#discussion_r200787876 --- Diff: src/config/Modules.yml --- @@ -50,3 +50,4 @@ modules: - name: validation depends: ['array_ops', 'regress

[GitHub] madlib issue #288: Jira:1239: Converts features from multiple columns into a...

2018-07-06 Thread hpandeycodeit
Github user hpandeycodeit commented on the issue: https://github.com/apache/madlib/pull/288 @fmcquillan99 , What is total_rows_processed and total_rows_skipped ? Can you provide more details on these? ---

[GitHub] madlib pull request #288: Madlib 1239

2018-07-03 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/288 Madlib 1239 JIRA: 1239 Added a new module cols_vec which Converts features from multiple columns of an input table into a feature array in a single column. Following files

[GitHub] madlib pull request #280: Changes for Jira: 1239, Converts features from mul...

2018-06-19 Thread hpandeycodeit
Github user hpandeycodeit closed the pull request at: https://github.com/apache/madlib/pull/280 ---

[GitHub] madlib issue #280: Changes for Jira: 1239, Converts features from multiple c...

2018-06-19 Thread hpandeycodeit
Github user hpandeycodeit commented on the issue: https://github.com/apache/madlib/pull/280 Discussed this with @kaknikhil Yesterday and some work still needs to be done for special characters. So closing this for now. ---

[GitHub] madlib pull request #280: Changes for Jira: 1239, Converts features from mul...

2018-06-15 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/280 Changes for Jira: 1239, Converts features from multiple columns i… JIRA: 1239 Added a new module cols_vec which Converts features from multiple columns of an input table

[GitHub] madlib pull request #270: Jira 1172

2018-05-22 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/270 Jira 1172 JIRA MADLIB-1172: When the model cannot be generated due to the ill-conditioned input data, the output table doesn't get populated. In that case, Print the below

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

2018-03-20 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175952795 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -527,14 +562,63 @@ def pagerank(schema_madlib, vertex_table, vertex_id, edge_table

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

2018-03-20 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175952633 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -527,14 +562,63 @@ def pagerank(schema_madlib, vertex_table, vertex_id, edge_table

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

2018-03-20 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/244#discussion_r175952712 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -44,29 +44,40 @@ from utilities.utilities import add_postfix from

[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

2018-03-16 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/244 Changes for Personalized Page Rank : Jira:1084 Jira : 1084 This PR contains changes for Personalized Page Rank. - Added extra parameter, nodes_of_interest in main pagerank

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-29 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r164594150 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -72,43 +72,55 @@ copy knn_test_data (id, data) from stdin delimiter

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-29 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r164593774 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -212,22 +244,27 @@ def knn(schema_madlib, point_source, point_column_name, point_id

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-19 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r162684994 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -326,6 +331,39 @@ Result, with neighbors sorted from closest to furthest: (6 rows

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-19 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r162685159 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -412,7 +451,8 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.knn( output_table

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-19 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r162684704 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -211,23 +222,43 @@ def knn(schema_madlib, point_source, point_column_name, point_id

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-16 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/225 Added option for weighted average for both classification and regress… Added option for weighted average for both classification and regression Models. Jira#1181 You can merge this pull

[GitHub] madlib pull request #204: Added additional distance metrics for k-NN: Jira-1...

2017-11-30 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/204#discussion_r154183869 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -89,20 +89,20 @@ def knn_validate_src(schema_madlib, point_source, point_column_name

[GitHub] madlib pull request #204: Added additional distance metrics for k-NN: Jira-1...

2017-11-21 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/204#discussion_r152419373 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -73,23 +73,23 @@ copy knn_test_data (id, data) from stdin delimiter

[GitHub] madlib pull request #204: Added additional distance metrics for k-NN: Jira-1...

2017-11-21 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/204#discussion_r152419209 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -88,12 +88,28 @@ def knn_validate_src(schema_madlib, point_source, point_column_name

[GitHub] madlib pull request #204: Added additional distance metrics for k-NN: Jira-1...

2017-11-20 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/204 Added additional distance metrics for k-NN: Jira-1059 You can merge this pull request into a Git repository by running: $ git pull https://github.com/hpandeycodeit/incubator-madlib

[GitHub] madlib pull request #184: Knn dev 1129

2017-10-12 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/184#discussion_r144390792 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -55,15 +71,23 @@ copy knn_test_data (id, "DATA") from stdin delimiter '

[GitHub] madlib pull request #183: Knn 1129

2017-09-07 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/183 Knn 1129 KNN Changes for Jira#1129. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hpandeycodeit/incubator-madlib knn_1129