Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/295
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/630/
---
Github user fmcquillan99 commented on the issue:
https://github.com/apache/madlib/pull/295
LGTM, here is an RF example:
```
SELECT * FROM mt_imp_output ORDER BY am, oob_var_importance DESC;
am | feature | oob_var_importance | impurity_var_importance
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/295
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/610/
---
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/295
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/601/
---
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/295
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/592/
---
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/295
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/591/
---
Github user fmcquillan99 commented on the issue:
https://github.com/apache/madlib/pull/295
I like this last suggestion from @iyerr3, that we report raw values for oob
and impurity VI in the model output file. (OK to keep the shifted oob > 0 as
we do now.)
For the
Github user njayaram2 commented on the issue:
https://github.com/apache/madlib/pull/295
@fmcquillan only impurity, I don't think we scale oob to 100.
---
Github user fmcquillan commented on the issue:
https://github.com/apache/madlib/pull/295
Would this apply to oob too?
Or just impurity?
---
Github user iyerr3 commented on the issue:
https://github.com/apache/madlib/pull/295
Considering the above situation, I suggest the variable importance values
not be scaled to sum to 100. We can make the normalization within
`get_var_importance` just for the reporting (which is the
Github user fmcquillan99 commented on the issue:
https://github.com/apache/madlib/pull/295
Another run I got
```
grp 0 grp1
31.01364943 31.6576
22.85881741
Github user fmcquillan99 commented on the issue:
https://github.com/apache/madlib/pull/295
Should impurity_var_importance always add up to 100?
From the regression example in the user docs:
```
DROP TABLE IF EXISTS mt_imp_output;
SELECT
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/295
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/580/
---
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/295
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/579/
---
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/295
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/576/
---
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/295
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/573/
---
16 matches
Mail list logo
