[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-29 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r164594150 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -72,43 +72,55 @@ copy knn_test_data (id, data) from stdin delimiter '|'; \.

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-29 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r164593774 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -212,22 +244,27 @@ def knn(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-24 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r163653414 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -212,22 +244,27 @@ def knn(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-24 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r163657952 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -72,43 +72,55 @@ copy knn_test_data (id, data) from stdin delimiter '|'; \.

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-19 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r162684994 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -326,6 +331,39 @@ Result, with neighbors sorted from closest to furthest: (6 rows)

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-19 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r162685159 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -412,7 +451,8 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.knn( output_table,

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-19 Thread hpandeycodeit
Github user hpandeycodeit commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r162684704 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -211,23 +222,43 @@ def knn(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-16 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r161918108 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -326,6 +331,39 @@ Result, with neighbors sorted from closest to furthest: (6 rows)

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-16 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/225#discussion_r161917948 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -412,7 +451,8 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.knn( output_table,

[GitHub] madlib pull request #225: Added option for weighted average for both classif...

2018-01-16 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request: https://github.com/apache/madlib/pull/225 Added option for weighted average for both classification and regress… Added option for weighted average for both classification and regression Models. Jira#1181 You can merge this pull