[GitHub] madlib pull request #313: MLP: Simplify momentum and Nesterov updates

2018-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/313 ---

[GitHub] madlib pull request #313: MLP: Simplify momentum and Nesterov updates

2018-08-21 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/313#discussion_r211725199 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -192,18 +189,23 @@ MLP::getLossAndUpdateModel( // 1. normalize to per row update // 2.

[GitHub] madlib pull request #313: MLP: Simplify momentum and Nesterov updates

2018-08-21 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/313#discussion_r211725456 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -192,18 +189,23 @@ MLP::getLossAndUpdateModel( // 1. normalize to per row update // 2.

[GitHub] madlib pull request #313: MLP: Simplify momentum and Nesterov updates

2018-08-17 Thread iyerr3
GitHub user iyerr3 opened a pull request: https://github.com/apache/madlib/pull/313 MLP: Simplify momentum and Nesterov updates Momentum updates are complicated due to Nesterov requiring an initial update before gradient calculations. There is, however, a different form of the