[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/320 ---

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-17 Thread d
Github user d commented on a diff in the pull request: https://github.com/apache/madlib/pull/320#discussion_r218152329 --- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake --- @@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-13 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/320#discussion_r217489096 --- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake --- @@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-12 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/320#discussion_r217260823 --- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake --- @@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)

[GitHub] madlib pull request #320: Fix false positive for Postgres 10+

2018-09-12 Thread d
GitHub user d opened a pull request: https://github.com/apache/madlib/pull/320 Fix false positive for Postgres 10+ We used to mistake 9.3.24 as a higher version than Postgres 10 and stop matching it to the correct "port". This patch fixes that. You can merge this pull request