Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/240
---
Github user njayaram2 commented on the issue:
https://github.com/apache/madlib/pull/241
Another issue I found but forgot to mention in the review:
The `__id__` column has double values instead of integers. For instance, I
found values such as `0.2000` for that
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/241#discussion_r175548350
--- Diff:
src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in ---
@@ -0,0 +1,559 @@
+# coding=utf-8
+#
+# Licensed to the
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/241#discussion_r175588969
--- Diff:
src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in ---
@@ -0,0 +1,559 @@
+# coding=utf-8
+#
+# Licensed to the
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/241#discussion_r175593796
--- Diff:
src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in ---
@@ -0,0 +1,559 @@
+# coding=utf-8
+#
+# Licensed to the
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/241#discussion_r175531202
--- Diff:
src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in ---
@@ -0,0 +1,559 @@
+# coding=utf-8
+#
+# Licensed to the
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/241#discussion_r175522378
--- Diff: src/ports/postgres/modules/utilities/utilities.py_in ---
@@ -794,6 +794,41 @@ def collate_plpy_result(plpy_result_rows):
#
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/241#discussion_r175585050
--- Diff:
src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in ---
@@ -0,0 +1,559 @@
+# coding=utf-8
+#
+# Licensed to the
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/243
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/383/
---
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/245
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/382/
---
GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/245
Reduce Install Check run time
To reduce the total run time of install check, we looked at the top 5
modules that take longest and modified install check test cases. See each
commit for details.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/240
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/381/
---
12 matches
Mail list logo