[GitHub] madlib issue #276: Feature/dev check

2018-06-15 Thread njayaram2
Github user njayaram2 commented on the issue:

https://github.com/apache/madlib/pull/276
  
Thank you for the comments @iyerr3 , will make the changes you have 
requested.

Having one IC file for each module makes sense, but on Greenplum, for some 
modules the IC run time is still quite high. For example, if a module had 5 IC 
files, where each ran for 10 seconds, the user would see IC progressing every 
10 seconds. But if those were combined into one IC file, the progression would 
happen after 50 seconds. It seemed a little odd (longer IC run times for some 
modules in terms of user experience) when we were trying it out, so decided to 
keep multiple IC files for such modules.


---


[GitHub] madlib pull request #278: Upgrade: add changelist file and bug fixes

2018-06-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/madlib/pull/278


---


[GitHub] madlib issue #280: Changes for Jira: 1239, Converts features from multiple c...

2018-06-15 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/madlib/pull/280
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/516/



---


[GitHub] madlib pull request #280: Changes for Jira: 1239, Converts features from mul...

2018-06-15 Thread hpandeycodeit
GitHub user hpandeycodeit opened a pull request:

https://github.com/apache/madlib/pull/280

Changes for Jira: 1239, Converts features from multiple columns i…

JIRA: 1239

Added a new module cols_vec which Converts features from multiple columns 
of an input table into a feature array in a single column.

Following files are committed: 

1. cols2vec.py_in
2. cols2vec.sql_in
3. test/cols2vec.sql_in
4. Modules.yml


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hpandeycodeit/incubator-madlib MADLIB_1239

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/madlib/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #280


commit 3b5a7780dee45edb215351879c892945d2c59c4c
Author: hpandeycodeit 
Date:   2018-06-15T08:33:27Z

Changes for Jira: 1239, Converts features from multiple columns into a 
feature array

commit 06bef61bffe71bae5bb9956c650d39ae7e0d5ef8
Author: hpandeycodeit 
Date:   2018-06-15T08:41:10Z

added Module cols_vec




---