[GitHub] madlib issue #292: Internal: Add function to check column type for 1D array

Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/292 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/558/ ---

[GitHub] madlib issue #291: Feature: Vector to Columns

Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/291 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/556/ ---

[GitHub] madlib issue #292: Internal: Add function to check column type for 1D array

Github user ArvindSridhar commented on the issue: https://github.com/apache/madlib/pull/292 Sounds good. Just pushed a commit to this PR, will rebase and add back the original function to the original vec2cols PR tomorrow ---

[GitHub] madlib issue #292: Internal: Add function to check column type for 1D array

Github user iyerr3 commented on the issue: https://github.com/apache/madlib/pull/292 Yeah, the unit tests are unnecessary after this change. I vote to remove them, with just the function added back to the original PR. On Thu, Jul 12, 2018 at 5:26 PM Arvind

[GitHub] madlib issue #292: Internal: Add function to check column type for 1D array

Github user ArvindSridhar commented on the issue: https://github.com/apache/madlib/pull/292 Sounds good-just verified that plpy converts the SQL bool into a Python bool and not a Python string. It should be good to go now. Do we still want to get rid of the unit tests now given that

[GitHub] madlib issue #290: madpack: Add madpack option to run unit tests.

Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/290 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/555/ ---

[GitHub] madlib issue #292: Internal: Add function to check column type for 1D array

Github user iyerr3 commented on the issue: https://github.com/apache/madlib/pull/292 That's a valid concern. You could return bool(result[0]['n_y']) to ensure a bool output instead of a string (though I believe the SPI ensures that boolean from SQL is returned as bool in

[GitHub] madlib pull request #287: Fix incorrect dict expansion in table header

Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/287 ---

[GitHub] madlib pull request #286: Build: Remove symlinks during rpm uninstall

Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/286 ---

[GitHub] madlib pull request #293: Utilities: Add check for whether type is of any ar...

Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/293 ---

[GitHub] madlib issue #292: Internal: Add function to check column type for 1D array

Github user iyerr3 commented on the issue: https://github.com/apache/madlib/pull/292 Few comments: 1. The query would read better if it is setup to return a boolean i.e. using `array_upper(..., 2) IS NULL` instead of converting the integer output to bool in Python. 2. My

[GitHub] madlib issue #292: Internal: Add function to check column type for 1D array

Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/292 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/554/ ---

[GitHub] madlib issue #292: Internal: Add function to check column type for 1D array

Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/292 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/553/ ---

[GitHub] madlib issue #293: Utilities: Add check for whether type is of any array var...

Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/293 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/552/ ---

[GitHub] madlib pull request #291: Feature: Vector to Columns

Github user ArvindSridhar commented on a diff in the pull request: https://github.com/apache/madlib/pull/291#discussion_r202140243 --- Diff: src/ports/postgres/modules/utilities/test/unit_tests/test_utilities.py_in --- @@ -243,6 +243,9 @@ class

[GitHub] madlib pull request #292: Internal: Add function to check column type for 1D...

GitHub user ArvindSridhar opened a pull request: https://github.com/apache/madlib/pull/292 Internal: Add function to check column type for 1D array Added a db_utils function to check whether a column of type array contains 1D arrays only You can merge this pull request into a Git

[GitHub] madlib issue #291: Feature: Vector to Columns

Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/291 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/551/ ---

[GitHub] madlib issue #291: Feature: Vector to Columns

Github user fmcquillan99 commented on the issue: https://github.com/apache/madlib/pull/291 user docs seem incomplete ---

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/282 ---

[GitHub] madlib issue #290: madpack: Add madpack option to run unit tests.

Github user njayaram2 commented on the issue: https://github.com/apache/madlib/pull/290 Thank you for the comments @iyerr3 , will do the needful. ---

[GitHub] madlib issue #282: Utilites: Add CTAS while dropping some columns

Github user fmcquillan99 commented on the issue: https://github.com/apache/madlib/pull/282 ah, i see. I think it is fine as you have put it. LGTM ---