[GitHub] madlib issue #314: Ubuntu support: Enable creation of gppkg on Ubuntu

2018-08-22 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/madlib/pull/314
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/657/



---


[GitHub] madlib pull request #314: Ubuntu support: Enable creation of gppkg on Ubuntu

2018-08-22 Thread njayaram2
GitHub user njayaram2 opened a pull request:

https://github.com/apache/madlib/pull/314

Ubuntu support: Enable creation of gppkg on Ubuntu

This commit makes necessary changes to create a gppkg on Ubuntu. The
default behavior when MADlib is built on Ubuntu is to create a .deb
installer. If we want to create a gppkg, then we need an RPM due to
limitations in gppkg. We now create an RPM on Ubuntu (assuming package
alien is installed on Ubuntu) if the right cmake flag is specified. Once
an RPM is created on `make package`, we can now go ahead and create the
gppkg using `make gppkg`.
The cmake flag to use if we want to create an .rpm instead of .deb on
Ubuntu when we run `make package` is:
-DCREATE_RPM_FOR_UBUNTU=True

Co-authored-by: Orhan Kislal 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/madlib/madlib ubuntu-gppkg-support

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/madlib/pull/314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #314


commit bd85bae33473e697d7c26fdac9ee3253ff9a82b3
Author: Nandish Jayaram 
Date:   2018-08-06T22:19:18Z

Ubuntu support: Enable creation of gppkg on Ubuntu

This commit makes necessary changes to create a gppkg on Ubuntu. The
default behavior when MADlib is built on Ubuntu is to create a .deb
installer. If we want to create a gppkg, then we need an RPM due to
limitations in gppkg. We now create an RPM on Ubuntu (assuming package
alien is installed on Ubuntu) if the right cmake flag is specified. Once
an RPM is created on `make package`, we can now go ahead and create the
gppkg using `make gppkg`.
The cmake flag to use if we want to create an .rpm instead of .deb on
Ubuntu when we run `make package` is:
-DCREATE_RPM_FOR_UBUNTU=True

Co-authored-by: Orhan Kislal 




---