[GitHub] madlib issue #328: Graph: Add id of nodes with 0 in-degree
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/328 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/695/ ---
[GitHub] madlib issue #328: Graph: Add id of nodes with 0 in-degree
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/328 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/694/ ---
[GitHub] madlib issue #327: Upgrade: Fix issue with upgrading RPM to 1.15.1
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/327 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/693/ ---
[GitHub] madlib pull request #327: Upgrade: Fix issue with upgrading RPM to 1.15.1
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/327 Upgrade: Fix issue with upgrading RPM to 1.15.1 JIRA: MADLIB-1278 During RPM upgrade, rpm_post.sh is run first, followed by rpm_post_uninstall.sh. So we must do all the uninstallation specific stuff based on the current operation being uninstall or upgrade. This commit makes the necessary change to remove symlinks only during uninstallation, and not while upgrading. Co-authored-by: Domino Valdano You can merge this pull request into a Git repository by running: $ git pull https://github.com/madlib/madlib rpm-upgrade-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/madlib/pull/327.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #327 commit 8234449be7d8522aa6d351bf504a573558cad4d3 Author: Nandish Jayaram Date: 2018-10-01T21:32:44Z Upgrade: Fix issue with upgrading RPM to 1.15.1 JIRA: MADLIB-1278 During RPM upgrade, rpm_post.sh is run first, followed by rpm_post_uninstall.sh. So we must do all the uninstallation specific stuff based on the current operation being uninstall or upgrade. This commit makes the necessary change to remove symlinks only during uninstallation, and not while upgrading. Co-authored-by: Domino Valdano ---
[GitHub] madlib issue #326: Install/Dev check: Add new test cases for some modules
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/326 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/692/ ---
[GitHub] madlib pull request #326: Install/Dev check: Add new test cases for some mod...
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/326#discussion_r221714858 --- Diff: src/ports/postgres/modules/pmml/test/pmml.ic.sql_in --- @@ -0,0 +1,119 @@ +/* --- *//** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + *//* --- */ +DROP TABLE IF EXISTS abalone CASCADE; + +CREATE TABLE abalone ( +id integer, +sex text, +length double precision, +diameter double precision, +height double precision, +whole double precision, +shucked double precision, +viscera double precision, +shell double precision, +rings integer +); + +INSERT INTO abalone VALUES +(3151, 'F', 0.655027, 0.505004, 0.165008, 1.36699, 0.583519, 0.351479, 0.396019, 10), +(2026, 'F', 0.550044, 0.469973, 0.149994, 0.920485, 0.381005, 0.243494, 0.267516, 10), +(3751, 'I', 0.434998, 0.375, 0.110001, 0.41548, 0.170012, 0.0759981, 0.14499, 8), +(720, 'I', 0.149994, 0.16, 0.0250014, 0.0149994, 0.00449966, 0.0048, 0.0050001, 2), +(1635, 'F', 0.574956, 0.469973, 0.154999, 1.1161, 0.509008, 0.237989, 0.340024, 10), +(2648, 'I', 0.5, 0.390013, 0.125, 0.582963, 0.293984, 0.132006, 0.160504, 8), +(1796, 'F', 0.57996, 0.429993, 0.170012, 1.47998, 0.65347, 0.32401, 0.41548, 10), +(209, 'F', 0.525022, 0.41498, 0.170012, 0.832518, 0.275523, 0.168511, 0.309998, 13), +(1451, 'I', 0.455016, 0.33502, 0.135009, 0.501001, 0.274021, 0.0995051, 0.106497, 7), +(1108, 'I', 0.510009, 0.380004, 0.115005, 0.515458, 0.214997, 0.113504, 0.166009, 8), +(3675, 'F', 0.594973, 0.450011, 0.165008, 1.08096, 0.489991, 0.252502, 0.279026, 12), +(2108, 'F', 0.675044, 0.550044, 0.179993, 1.688499989, 0.562055, 0.370496, 0.599978, 15), +(3312, 'F', 0.479982, 0.380004, 0.135009, 0.507006, 0.191504, 0.13651, 0.154999, 12), +(882, 'M', 0.655027, 0.520018, 0.165008, 1.40948, 0.585965, 0.290981, 0.405027, 9), +(3402, 'M', 0.479982, 0.395018, 0.149994, 0.681495, 0.214496, 0.140514, 0.2495, 18), +(829, 'I', 0.409976, 0.325011, 0.16, 0.394017, 0.20799, 0.0655027, 0.105997, 6), +(1305, 'M', 0.535031, 0.434998, 0.149994, 0.716971, 0.347476, 0.14449, 0.194006, 9), +(3613, 'M', 0.599978, 0.46002, 0.179993, 1.1399, 0.422987, 0.257507, 0.364991, 10), +(1068, 'I', 0.340024, 0.265013, 0.0800017, 0.201512, 0.0899967, 0.0475006,
[GitHub] madlib pull request #326: Install/Dev check: Add new test cases for some mod...
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/326#discussion_r221712133 --- Diff: methods/stemmer/src/pg_gp/test/porter_stemmer.sql_in --- @@ -0,0 +1,38 @@ +/* --- *//** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + *//* --- */ + +CREATE TABLE token_tbl ( id integer, --- End diff -- Noticed the install check and dev check test cases are exactly the same as each other. Is it better to differentiate them? ---
[GitHub] madlib issue #326: Install/Dev check: Add new test cases for some modules
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/326 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/691/ ---
[GitHub] madlib pull request #326: Install/Dev check: Add new test cases for some mod...
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/326 Install/Dev check: Add new test cases for some modules Some modules such as array_ops and pmml did not have any install check files, while stemmer did not have any test files. This commit adds some basic test cases for these modules. You can merge this pull request into a Git repository by running: $ git pull https://github.com/madlib/madlib ic-pmml-stemmer Alternatively you can review and apply these changes as the patch at: https://github.com/apache/madlib/pull/326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #326 commit 0928be85ac504ae90ec6a2f2de694cd5aa2440f7 Author: Nandish Jayaram Date: 2018-09-29T00:15:40Z Install/Dev check: Add new test cases for some modules Some modules such as array_ops and pmml did not have any install check files, while stemmer did not have any test files. This commit adds some basic test cases for these modules. ---
[GitHub] madlib issue #325: Madpack/ic func schema
Github user orhankislal commented on the issue: https://github.com/apache/madlib/pull/325 > Also note: madpack is supposed to drop the file-specific schema after executing each file (see function _execute_per_module_install_dev_check_algo). Hence, common table names in independent tests within same module are not supposed to conflict with each other (if you've seen this happen then it requires investigation). Oh, I see. The naming convention is somewhat strange. Under the modules folder, we have a bunch of folders (graph, etc.) but they are not actually modules, the individual sql files are. The madpack code uses the variable `module` for the folder name which further muddles the naming. This means `madlib_installcheck_graph` schema will be created and dropped for each module in graph. We might want to change it to reflect the actual module name. I think the reused name issue might be more widespread than we think. I am pretty sure `abalone` and `houses` datasets are used in multiple modules. I think removing the `DROP TABLE` statements might work as @iyerr3 suggested. I'll keep the PR open for now to keep the conversation open and start working on a different branch. ---
